Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin source missing #2

Open
ProdigySim opened this issue Aug 14, 2014 · 16 comments
Open

Plugin source missing #2

ProdigySim opened this issue Aug 14, 2014 · 16 comments

Comments

@ProdigySim
Copy link
Member

We don't have any plugin source here. Are we planning to find and include it all, or is there something else planned?

@rpdelaney
Copy link
Contributor

As far as I know, Promod distribution packages haven't included plugin sources for a very long time. It is likely that this is a copyright infringement. @Attano has acknowledged the problem and based on how Equilibrium development was done, I think we can be optimistic that this will get corrected over time.

@rpdelaney
Copy link
Contributor

@Attano
Copy link
Member

Attano commented Aug 15, 2014

If anyone is willing to help, make a separate issue in this repo with the list of all the plugins that are missing sources.

@rpdelaney
Copy link
Contributor

Not sure if :trollface: or not. None of the plugins distributed have any sources. Here's a gist with all the plugins included in the most recent "release" of Promod, as of this writing.

https://gist.github.com/rpdelaney/ed818aa7e9111bcf1894

@ProdigySim
Copy link
Member Author

This is github. There is not trolling. Only cold, emotionless verbosity.

@ProdigySim
Copy link
Member Author

I'm also kind of interested if anyone can think of a better plan than including a bunch of source sp files in here. We could do git submodules, or pull the sources from another place at build time, etc.

@rpdelaney
Copy link
Contributor

Git submodules would be ideal. No doubt amateur devs will be mystified by all the "unnecessary" complexity although it should have been done that way from the beginning.

@rpdelaney
Copy link
Contributor

Didn't some of @CanadaRox's stuff have build scripts for the sources? That could be worth looking into, for our own sanity at the very least.

@ProdigySim
Copy link
Member Author

I think the stuff in here is the closest we've had to a major build system like that. The Makefile + clone_repos.sh.

Also that setup was unused, since it was for LGOFNOC-based Confogl3--which nobody has really picked up on using, although I think some tried. My basic plan with that was to try to get all config makers to use one single repo and consolidate plugin versions and stuff--while still keeping their "configs" separate. I stopped work on it though.

@MatthewClair
Copy link
Member

My ready-up repo has some a basic Makefile: https://github.com/CanadaRox/l4d2readyup/blob/master/Makefile

@Attano
Copy link
Member

Attano commented Aug 20, 2014

None of the plugins distributed have any sources.

I don't know who deleted all the sources. Anyway, I still have some old Promod forks with Confogl-compatible sources. Some sources from Stabby and Epilimic's Promod repos, apparently, are LGOFNOC versions, so we don't need that.

@ProdigySim
Copy link
Member Author

I really like the idea of centralizing all source in one repo better. Seems like less repo management fuss will have to be done. Submodules do require extra maintenance, and I don't think there are other repos which are better organized on their own containing these plugins.

@rpdelaney
Copy link
Contributor

@ProdigySim , I created a separate issue for discussing submodules.

@ProdigySim
Copy link
Member Author

Do we have everything we need as of 62e8eaa or are we still missing some?

@Attano
Copy link
Member

Attano commented Aug 30, 2014

Not only are we missing 80% of stuff after that commit, but it also seems to contain random modules from confoglcompmod that aren't even compilable. I'm going to restructurize everything soon.

@Attano
Copy link
Member

Attano commented Sep 3, 2014

https://github.com/Attano/L4D2-Competitive-Framework/

This contains all the plugins and sources used by modern configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants