{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":87824519,"defaultBranch":"master","name":"impressionist","ownerLogin":"ConvertKit","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2017-04-10T15:04:31.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/10557747?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1704304306.0","currentOid":""},"activityList":{"items":[{"before":"a69b466e7df135abeddb9e387572ff4d2a607891","after":null,"ref":"refs/heads/sb-rails-7","pushedAt":"2024-01-03T17:51:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"stefannibrasil","name":"Stefanni Brasil","path":"/stefannibrasil","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10670581?s=80&v=4"}},{"before":"59c8f00d409db6facc5564c8fa2d194beef36182","after":"ece010a1cde9f5187a2614deb7ac54bb885a903c","ref":"refs/heads/master","pushedAt":"2024-01-03T17:51:43.000Z","pushType":"pr_merge","commitsCount":8,"pusher":{"login":"stefannibrasil","name":"Stefanni Brasil","path":"/stefannibrasil","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10670581?s=80&v=4"},"commit":{"message":"Merge pull request #3 from ConvertKit/sb-rails-7\n\nUpgrade to Rails 7","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2056722779\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ConvertKit/impressionist/issues/3\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ConvertKit/impressionist/pull/3/hovercard\" href=\"https://github.com/ConvertKit/impressionist/pull/3\">#3</a> from ConvertKit/sb-rails-7"}},{"before":"75ce5be5c847babc39233086110fbd05954c37e8","after":"a69b466e7df135abeddb9e387572ff4d2a607891","ref":"refs/heads/sb-rails-7","pushedAt":"2024-01-02T19:05:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"stefannibrasil","name":"Stefanni Brasil","path":"/stefannibrasil","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10670581?s=80&v=4"},"commit":{"message":"Support any Rails version >= 6.1..7.6\n\nThese changes allow us to support Rails 7.1, so we can remove the\nsecond constraint completely. Otherwise, when we upgrade it to > 7.1,\nwe will need to update the version again.","shortMessageHtmlLink":"Support any Rails version &gt;= 6.1..7.6"}},{"before":"7722ad8a01df01316eb23b835f586ba33e99e862","after":"75ce5be5c847babc39233086110fbd05954c37e8","ref":"refs/heads/sb-rails-7","pushedAt":"2023-12-26T22:01:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"stefannibrasil","name":"Stefanni Brasil","path":"/stefannibrasil","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10670581?s=80&v=4"},"commit":{"message":"Allow Rails > 6.1 and < 7 versions\n\notherwise, we can't upgrade this gem on the main app ;)","shortMessageHtmlLink":"Allow Rails &gt; 6.1 and &lt; 7 versions"}},{"before":"59c8f00d409db6facc5564c8fa2d194beef36182","after":null,"ref":"refs/heads/sb-rails-7-upgrade","pushedAt":"2023-12-26T21:58:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"stefannibrasil","name":"Stefanni Brasil","path":"/stefannibrasil","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10670581?s=80&v=4"}},{"before":"51c93fbd2ed3a935ec7c651c365aa341a428e694","after":"7722ad8a01df01316eb23b835f586ba33e99e862","ref":"refs/heads/sb-rails-7","pushedAt":"2023-12-26T21:52:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"stefannibrasil","name":"Stefanni Brasil","path":"/stefannibrasil","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10670581?s=80&v=4"},"commit":{"message":"ActiveRecord::Base is not accessible anymore\n\nsince https://github.com/rails/rails/pull/42445, this method has been\nchanged from cattr_accessor to attr_accessor in ActiveRecord.","shortMessageHtmlLink":"ActiveRecord::Base is not accessible anymore"}},{"before":"59c8f00d409db6facc5564c8fa2d194beef36182","after":"51c93fbd2ed3a935ec7c651c365aa341a428e694","ref":"refs/heads/sb-rails-7","pushedAt":"2023-12-26T21:36:32.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"stefannibrasil","name":"Stefanni Brasil","path":"/stefannibrasil","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10670581?s=80&v=4"},"commit":{"message":"Remove deprecated `legacy_connection_handling` setter\n\nThis was deprecated in 7.0 and removed in 7.1. This config no longer has\neffects since multiple databases config in Rails has to be configured\nmanually. It is now set to false by default.","shortMessageHtmlLink":"Remove deprecated <code>legacy_connection_handling</code> setter"}},{"before":null,"after":"59c8f00d409db6facc5564c8fa2d194beef36182","ref":"refs/heads/sb-rails-7","pushedAt":"2023-12-26T21:34:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"stefannibrasil","name":"Stefanni Brasil","path":"/stefannibrasil","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10670581?s=80&v=4"},"commit":{"message":"Autoload issue with ImpressionistController (#2)\n\nInstead of depending on autoload to bring in the ImpressionistController\r\nconstant, we manually bring it with a call to require and just move that file\r\nto lib.\r\n\r\nPrior to this, Rails would emit a warning on startup about needing to use\r\nautoload durning an initializer like this, letting us know that a future\r\nversion of Rails will error.\r\n\r\nThis should hopefully remove that error and still allow these controller mixins\r\nto be available.  Note that Rails 7.1 will eventually be a future blocker here.\r\n\r\nPS. This is the recommended approach by Xavier here:\r\nhttps://github.com/charlotte-ruby/impressionist/issues/305\r\n\r\nCo-authored-by: stefannibrasil <10670581+stefannibrasil@users.noreply.github.com>","shortMessageHtmlLink":"Autoload issue with ImpressionistController (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1936015125\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ConvertKit/impressionist/issues/2\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ConvertKit/impressionist/pull/2/hovercard\" href=\"https://github.com/ConvertKit/impressionist/pull/2\">#2</a>)"}},{"before":"bcb238de0b5099c7711da57e9110980b4dadf65b","after":"59c8f00d409db6facc5564c8fa2d194beef36182","ref":"refs/heads/sb-rails-7-upgrade","pushedAt":"2023-12-26T21:32:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"stefannibrasil","name":"Stefanni Brasil","path":"/stefannibrasil","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10670581?s=80&v=4"},"commit":{"message":"Autoload issue with ImpressionistController (#2)\n\nInstead of depending on autoload to bring in the ImpressionistController\r\nconstant, we manually bring it with a call to require and just move that file\r\nto lib.\r\n\r\nPrior to this, Rails would emit a warning on startup about needing to use\r\nautoload durning an initializer like this, letting us know that a future\r\nversion of Rails will error.\r\n\r\nThis should hopefully remove that error and still allow these controller mixins\r\nto be available.  Note that Rails 7.1 will eventually be a future blocker here.\r\n\r\nPS. This is the recommended approach by Xavier here:\r\nhttps://github.com/charlotte-ruby/impressionist/issues/305\r\n\r\nCo-authored-by: stefannibrasil <10670581+stefannibrasil@users.noreply.github.com>","shortMessageHtmlLink":"Autoload issue with ImpressionistController (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1936015125\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ConvertKit/impressionist/issues/2\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ConvertKit/impressionist/pull/2/hovercard\" href=\"https://github.com/ConvertKit/impressionist/pull/2\">#2</a>)"}},{"before":"decfda2708b7688f32c2aaaec4e3405b4a75f7e8","after":"bcb238de0b5099c7711da57e9110980b4dadf65b","ref":"refs/heads/sb-rails-7-upgrade","pushedAt":"2023-12-26T21:31:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"stefannibrasil","name":"Stefanni Brasil","path":"/stefannibrasil","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10670581?s=80&v=4"},"commit":{"message":"Fix fixtures_path deprecation\n\nWith Rails 7.1.2, configuring `fixture_path` has been deprecated in\nfavor of using an aray of `fixture_paths`.","shortMessageHtmlLink":"Fix fixtures_path deprecation"}},{"before":null,"after":"decfda2708b7688f32c2aaaec4e3405b4a75f7e8","ref":"refs/heads/sb-rails-7-upgrade","pushedAt":"2023-12-26T21:27:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"stefannibrasil","name":"Stefanni Brasil","path":"/stefannibrasil","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10670581?s=80&v=4"},"commit":{"message":"Fix fixtures_path deprecation\n\nWith Rails 7.1.2, configuring `fixture_path` has been deprecated in\nfavor of using an aray of `fixture_paths`.","shortMessageHtmlLink":"Fix fixtures_path deprecation"}},{"before":"0053c8ae6a05a7ddb1f031f1b0e07cfd6b6ffef1","after":null,"ref":"refs/heads/brendancarney-patch-1","pushedAt":"2023-10-17T14:52:09.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"cainwatson","name":"Cain Watson","path":"/cainwatson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/23223956?s=80&v=4"}},{"before":"b3395268ee0e42f03efb64867d7482a06164974c","after":null,"ref":"refs/heads/green-builds","pushedAt":"2023-10-17T14:52:07.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"cainwatson","name":"Cain Watson","path":"/cainwatson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/23223956?s=80&v=4"}},{"before":"c91deb03d031dfc41cb80cc1cd4c65cc5cab2fe9","after":null,"ref":"refs/heads/fix_issue_123","pushedAt":"2023-10-17T14:52:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"cainwatson","name":"Cain Watson","path":"/cainwatson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/23223956?s=80&v=4"}},{"before":"7ab7dd0aab436b5c8614b41d72284371672af6b8","after":null,"ref":"refs/heads/2.0.rc1","pushedAt":"2023-10-17T14:52:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"cainwatson","name":"Cain Watson","path":"/cainwatson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/23223956?s=80&v=4"}},{"before":"d3ae52164e12c670866f6befd29db0690b4c5e84","after":null,"ref":"refs/heads/sb-rk-autoload-controller-fix","pushedAt":"2023-10-16T21:58:01.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"stefannibrasil","name":"Stefanni Brasil","path":"/stefannibrasil","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10670581?s=80&v=4"}},{"before":"b02be39feafd3301e0786e6e67c0d07021bf42d5","after":"59c8f00d409db6facc5564c8fa2d194beef36182","ref":"refs/heads/master","pushedAt":"2023-10-16T20:54:34.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"keegnotrub","name":"Ryan Krug","path":"/keegnotrub","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1398?s=80&v=4"},"commit":{"message":"Autoload issue with ImpressionistController (#2)\n\nInstead of depending on autoload to bring in the ImpressionistController\r\nconstant, we manually bring it with a call to require and just move that file\r\nto lib.\r\n\r\nPrior to this, Rails would emit a warning on startup about needing to use\r\nautoload durning an initializer like this, letting us know that a future\r\nversion of Rails will error.\r\n\r\nThis should hopefully remove that error and still allow these controller mixins\r\nto be available.  Note that Rails 7.1 will eventually be a future blocker here.\r\n\r\nPS. This is the recommended approach by Xavier here:\r\nhttps://github.com/charlotte-ruby/impressionist/issues/305\r\n\r\nCo-authored-by: stefannibrasil <10670581+stefannibrasil@users.noreply.github.com>","shortMessageHtmlLink":"Autoload issue with ImpressionistController (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1936015125\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ConvertKit/impressionist/issues/2\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ConvertKit/impressionist/pull/2/hovercard\" href=\"https://github.com/ConvertKit/impressionist/pull/2\">#2</a>)"}},{"before":"57c1f9805381a4d558c792e77e486e0f21617676","after":"d3ae52164e12c670866f6befd29db0690b4c5e84","ref":"refs/heads/sb-rk-autoload-controller-fix","pushedAt":"2023-10-10T21:47:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"stefannibrasil","name":"Stefanni Brasil","path":"/stefannibrasil","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10670581?s=80&v=4"},"commit":{"message":"Rename references to new file","shortMessageHtmlLink":"Rename references to new file"}},{"before":"f87e5709c689e815fe7aa5bb39544cbeeba619c3","after":"57c1f9805381a4d558c792e77e486e0f21617676","ref":"refs/heads/sb-rk-autoload-controller-fix","pushedAt":"2023-10-10T20:22:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"keegnotrub","name":"Ryan Krug","path":"/keegnotrub","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1398?s=80&v=4"},"commit":{"message":"Breakage in Rails 7.1?","shortMessageHtmlLink":"Breakage in Rails 7.1?"}},{"before":"1c5bfe9c2eeee7d4de9eba73de9fd200f21acd4d","after":"f87e5709c689e815fe7aa5bb39544cbeeba619c3","ref":"refs/heads/sb-rk-autoload-controller-fix","pushedAt":"2023-10-10T18:30:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"keegnotrub","name":"Ryan Krug","path":"/keegnotrub","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1398?s=80&v=4"},"commit":{"message":"Autoload issue with ImpressionistController\n\nInstead of depending on autoload to bring in the\n`ImpressionistController` constant, we manually bring it with a call\nto `require` and just move that file to `lib`.\n\nPrior to this, Rails would emit a warning on startup about needing to\nuse autoload durning an initializer like this, letting us know that a\nfuture version of Rails will error from this.\n\nThis should hopefully remove that error and still allow these\ncontroller mixins to be available.\n\nCo-authored-by: stefannibrasil <10670581+stefannibrasil@users.noreply.github.com>","shortMessageHtmlLink":"Autoload issue with ImpressionistController"}},{"before":"42e3145e8c6b018d494e86e3a07de8c6ec6a1692","after":"1c5bfe9c2eeee7d4de9eba73de9fd200f21acd4d","ref":"refs/heads/sb-rk-autoload-controller-fix","pushedAt":"2023-10-10T18:26:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"keegnotrub","name":"Ryan Krug","path":"/keegnotrub","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1398?s=80&v=4"},"commit":{"message":"Autoload issue with ImpressionistController\n\nInstead of depending on autoload to bring in the\n`ImpressionistController` constant, we manually bring it with a call\nto `require` and just move that file to `lib`.\n\nPrior to this, Rails would emit a warning on startup about needing to\nuse autoload durning an initializer like this, letting us know that a\nfuture version of Rails will error from this.\n\nThis should hopefully remove that error and still allow these\ncontroller mixins to be available.\n\nCo-authored-by: stefannibrasil <stefanni@thoughtbot.com>","shortMessageHtmlLink":"Autoload issue with ImpressionistController"}},{"before":null,"after":"42e3145e8c6b018d494e86e3a07de8c6ec6a1692","ref":"refs/heads/sb-rk-autoload-controller-fix","pushedAt":"2023-10-10T18:20:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"keegnotrub","name":"Ryan Krug","path":"/keegnotrub","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1398?s=80&v=4"},"commit":{"message":"Autoload issue with ImpressionistController\n\nInstead of depending on autoload to bring in the\n`ImpressionistController` constant, we manually bring it with a call\nto `require` and just move that file to `lib`.\n\nPrior to this, Rails would emit a warning on startup about needing to\nuse autoload durning an initializer like this, letting us know that a\nfuture version of Rails will error from this.\n\nThis should hopefully remove that error and still allow these\ncontroller mixins to be available.","shortMessageHtmlLink":"Autoload issue with ImpressionistController"}},{"before":"b2d9702caa6ff4589a88eb5d850c82c15b41e14d","after":"b02be39feafd3301e0786e6e67c0d07021bf42d5","ref":"refs/heads/master","pushedAt":"2023-06-14T19:05:24.859Z","pushType":"push","commitsCount":1,"pusher":{"login":"mercedesb","name":"Mercedes","path":"/mercedesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9774690?s=80&v=4"},"commit":{"message":"lint fix model_spec","shortMessageHtmlLink":"lint fix model_spec"}},{"before":"a2a4d6848f9d7ff70b16c29da516dbdd5c708151","after":"b2d9702caa6ff4589a88eb5d850c82c15b41e14d","ref":"refs/heads/master","pushedAt":"2023-06-14T18:56:44.383Z","pushType":"push","commitsCount":93,"pusher":{"login":"mercedesb","name":"Mercedes","path":"/mercedesb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9774690?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'upstream/master'","shortMessageHtmlLink":"Merge remote-tracking branch 'upstream/master'"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAD1wrlOwA","startCursor":null,"endCursor":null}},"title":"Activity · ConvertKit/impressionist"}