Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compareUrl: url parameters broken #131

Closed
mpalpha opened this issue Sep 5, 2019 · 1 comment
Closed

compareUrl: url parameters broken #131

mpalpha opened this issue Sep 5, 2019 · 1 comment

Comments

@mpalpha
Copy link

mpalpha commented Sep 5, 2019

When passing the following configuration options:

"auto-changelog": {
    "output": "README.md",
    "template": "assets/templates/changelog.hbs",
    "compareUrl": "http://<enterprise bitbucket server repo url>/compare/diff?targetBranch=refs%2Ftags%2F{from}&sourceBranch=refs%2Ftags%2F{to}"
}

The "equals" character is encoded to:

http://<enterprise bitbucket server repo url>/compare/diff?targetBranch&#x3D;refs%2Ftags%2F1.0.1&amp;sourceBranch&#x3D;refs%2Ftags%2F1.0.2

which is required for custom bitbucket servers, not bitbucket.org

@mpalpha mpalpha changed the title compareUrl: url parameters not working compareUrl: url parameters broken Sep 5, 2019
RomainDazy pushed a commit to RomainDazy/auto-changelog that referenced this issue Sep 27, 2019
RomainDazy pushed a commit to RomainDazy/auto-changelog that referenced this issue Sep 27, 2019
RomainDazy pushed a commit to RomainDazy/auto-changelog that referenced this issue Sep 28, 2019
@cookpete
Copy link
Owner

As of v1.16.2, the noEscape option is used to prevent Handlebars from automatically escaping anything in the templates. This should hopefully fix all issues around escaped characters in templates.

The only processing still done is manually encoding < and > characters in commit subjects to prevent markdown layout breaking: 575dcc9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants