Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Use = and & in compare URLs ( #131) #133

Closed
wants to merge 1 commit into from

Conversation

RomainDazy
Copy link

As stated in issue #131, the release comparison URLs for corporate Bitbucket servers include special characters = and &.

This commit currently replaces respective HTML entity names for = and & in the whole generated output.
I could not think of a situation where it could break existing features, but let me know if this is the case.

This is my first contribution to this repository, so any feedback is welcome (even outside of the diff, e.g. on a commit message policy I should follow, if any)

Thanks!

@RomainDazy
Copy link
Author

I faced an issue similar to #131, but in commit subjects, where backticks were printed as "`".
This occurred only when using a custom template, not with compact or keepachangelog.
I then realized that the difference between my custom template and the default ones is that they use "{{{subject}}}" rather than "{{subject}}".

I then updated the href section of the default templates to use triple curly brackets, which:

@RomainDazy RomainDazy changed the title Use = and & in compare URLs ( #131) [WIP] Use = and & in compare URLs ( #131) Sep 30, 2019
@RomainDazy
Copy link
Author

Cleanup done in tests

@RomainDazy RomainDazy changed the title [WIP] Use = and & in compare URLs ( #131) [READY] Use = and & in compare URLs ( #131) Oct 2, 2019
@cookpete cookpete closed this in 2b409c1 Oct 29, 2019
@cookpete
Copy link
Owner

Sorry for the delay on this. I really appreciate the effort, but ended up just using noEscape: true to prevent handlebars from escaping anything, which hopefully will solve all issues around this.

@RomainDazy Please don't be put off contributing! This was an awesome PR.

@RomainDazy
Copy link
Author

No problem ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants