fix parsing of --issue-url and -i options #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbwharris
force-pushed
the
fix-issue-url-override
branch
2 times, most recently
from
ff62be2
to
a1cffd0
Compare
bbwharris
force-pushed
the
fix-issue-url-override
branch
from
a1cffd0
to
7c5428d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of the option setup is important. The resulting object was placing the override in
Iinstead of the expectedissueUrlslot.This change corrects the option to restore the
--issue-urloverride (while preserving the -i option).I have also added a simple test case to protect you from future regressions.