Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services missing appProtocol definition #3435

Open
5 tasks done
szelenka opened this issue Oct 25, 2022 · 0 comments · May be fixed by #3436
Open
5 tasks done

Services missing appProtocol definition #3435

szelenka opened this issue Oct 25, 2022 · 0 comments · May be fixed by #3436

Comments

@szelenka
Copy link
Contributor

Please ensure you do the following when reporting a bug:

  • Provide a concise description of what the bug is.
  • Provide information about your environment.
  • Provide clear steps to reproduce the bug.
  • Attach applicable logs. Please do not attach screenshots showing logs unless you are unable to copy and paste the log data.
  • Ensure any code / output examples are properly formatted for legibility.

Overview

Kubernetes v1.18+ introduced Application Protocol for all Services. This is a simple field called appProtocol which identifies the application protocol being used on that service port.

The services created by the v5.2.0 PGO does not include these fields, which prevents other services looking for them to work with the Crunchy PGO. Such as Istio:
https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection

Environment

Please provide the following details:

  • Platform: Kubernetes
  • Platform Version: 1.22
  • PGO Image Tag: ubi8-5.2.0-0
  • Postgres Version 14
  • Storage: PVC

Steps to Reproduce

  1. Install latest Crunchy PGO
  2. Provision a new Instance
  3. Inspect Services created for the Instance, notice the port is missing the appProtocol field.

EXPECTED

  1. When creating a service, I would expect the Crunchy PGO to populate the appProtocol field appropriately.

ACTUAL

  1. No appProtocol field is populated

Logs

n/a

Additional Information

n/a

@szelenka szelenka linked a pull request Oct 25, 2022 that will close this issue
10 tasks
@cbandy cbandy linked a pull request Nov 10, 2022 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants