Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error handling in fallback #666

Open
shankars99 opened this issue Apr 8, 2022 · 1 comment
Open

Change error handling in fallback #666

shankars99 opened this issue Apr 8, 2022 · 1 comment

Comments

@shankars99
Copy link
Contributor

Chapter 15 (How to Build an Oracle - Part 2) contains the following code in the default workspace

the code within:

oracleContract.events.SetLatestEthPriceEvent(async (err, event) => {

has:

if (err) { 
      console.error('Error on event', err) 
      return 
    }
    // Do something
  })

however it expects:

if (err) console.error('Error on event', err)

changing the evaluator to accept either the first or change the default workspace to include the newer one would help solve the issue

@tholu
Copy link

tholu commented Apr 11, 2022

This is a problem in a lot of Lesson 15 chapters and rather frustrating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants