Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate method should read schema version from the file #332

Open
sonnb opened this issue Oct 6, 2023 · 0 comments
Open

validate method should read schema version from the file #332

sonnb opened this issue Oct 6, 2023 · 0 comments

Comments

@sonnb
Copy link

sonnb commented Oct 6, 2023

In the parse method, it does read the schema version from the source file which is working fine. But when users call the isValid or validate method without specify a schema version it always use latest version as default. This does not work for the case of XML since the xmlns in the source file does not match with the one in the latest version.

In library we have a method to get the schema version from the source file but this method is private and cannot be used by the users. It means in order to get correct version, users need to check themselves before hand.

I suggest we should read schema version automatically as we do with the parse method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant