fix: add missing Properties #39
Conversation
Signed-off-by: Mike de Senna <desenna@gmail.com>
Signed-off-by: Mike de Senna <desenna@gmail.com>
desenna
force-pushed
the
fix/vuln-properties
branch
from
2b2b2d8
to
db25930
Compare
Signed-off-by: Mike de Senna <desenna@gmail.com>
Signed-off-by: Mike de Senna <desenna@gmail.com>
There was a problem hiding this comment.
Thanks for the PR @desenna!
Besides TestVulnerability_Properties currently panicking, the snapshot files for valid-vulnerability.json and valid-vulnerability.xml have to be updated.
You can do that by running
UPDATE_SNAPSHOTS=true make testSigned-off-by: Mike de Senna <desenna@gmail.com>
Signed-off-by: Mike de Senna <desenna@gmail.com>
|
Welp, looks like you discovered a bug in the XML schema! 🚀 I filed a bug for this in the specification repo: CycloneDX/specification#147 Unfortunate, but it may take some time for the schema to be updated. For now you could comment out the properties in |
|
Yep, discovered a bug. Just wanted to check with my teammate that I wasn't crazy. Ok, going to add new commit now. |
This reverts commit 75c4a5f. Signed-off-by: Mike de Senna <desenna@gmail.com>
Signed-off-by: Mike de Senna <desenna@gmail.com>
| @@ -116,6 +116,12 @@ | |||
| </versions> | |||
| </target> | |||
| </affects> | |||
| <!-- <properties> | |||
|
Thanks for merging @nscuro . Any idea when this can be released as a v0.5.3 so we can use it? If easy to do, would it be possible to release today so I don't have to code a workaround on my side and then undo it? 😉 |
|
I'm on the go currently but I'll most likely release v0.6.0 later today. Give me 1-2 hours. |
|
@desenna Just pushed v0.6.0. Thanks again for your PR! |
Closes #38