Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for projects with multiple/nested workspaces #35

Open
MLSTRM opened this issue Mar 15, 2024 · 3 comments · May be fixed by #36
Open

feat: Support for projects with multiple/nested workspaces #35

MLSTRM opened this issue Mar 15, 2024 · 3 comments · May be fixed by #36
Labels
enhancement New feature or request

Comments

@MLSTRM
Copy link

MLSTRM commented Mar 15, 2024

Currently this plugin will only resolve the dependencies/components for a single workspace at a time, which can introduce additional complexity/complication when working in a multi-workspace monorepo.
Enhancing the plugin to recursively traverse all nested workspaces is quite a small change and would simplify the usage of this plugin in more complex projects, especially in cases where isolated reporting of BOM information is not required.

@jkowalleck jkowalleck added the enhancement New feature or request label Mar 15, 2024
@MLSTRM
Copy link
Author

MLSTRM commented Mar 15, 2024

I've made an initial proof of concept branch for what the change for this could look like on my own fork here for now https://github.com/MLSTRM/cyclonedx-node-yarn/tree/feature/nested-workspace-traversal - need to rebase past some changes in the last couple of days before I can raise a proper PR if deemed a useful thing to have

@jkowalleck
Copy link
Member

PRs are welcome. Please make sure to follow the contribution guidelines, and add relevant test cases and test-beds

@MLSTRM MLSTRM linked a pull request Mar 18, 2024 that will close this issue
@MLSTRM
Copy link
Author

MLSTRM commented Mar 18, 2024

PR raised + test added, also noticed the old snapshots weren't updated since the license resolution removal so I've updated those at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants