Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support deserialization of all known examples #537

Open
jkowalleck opened this issue Jan 25, 2024 · 4 comments · May be fixed by #538
Open

fix: support deserialization of all known examples #537

jkowalleck opened this issue Jan 25, 2024 · 4 comments · May be fixed by #538
Labels
bug Something isn't working

Comments

@jkowalleck
Copy link
Member

in https://github.com/CycloneDX/specification/tree/master/tools/src/test/resources
there are some example data, that do not work wit hthe deserialization of this library.

lets fix this
@jkowalleck jkowalleck added the bug Something isn't working label Jan 25, 2024
@jkowalleck jkowalleck self-assigned this Jan 25, 2024
@jkowalleck jkowalleck linked a pull request Jan 25, 2024 that will close this issue
Draft
@madpah
Copy link
Collaborator

madpah commented Apr 10, 2024

@jkowalleck - if I'm reading the current code in main correctly, this is already covered by the work you did to add schemaTestData used in test_validation_json.py and test_validation_xml.py?

@jkowalleck
Copy link
Member Author

[...] this is already covered by the work you did to add schemaTestData used in test_validation_json.py and test_validation_xml.py?

Nope. this issue is not about validating test data, but about deserializing the test data.
see how #538 failed?

@jkowalleck jkowalleck removed their assignment Apr 10, 2024
@madpah
Copy link
Collaborator

madpah commented Apr 10, 2024 •
edited

Gotcha! Will work on #581 and #422 first.

@jkowalleck
Copy link
Member Author

related: #600

@jkowalleck jkowalleck mentioned this issue May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] fix: deserialization of XML/JSON CycloneDX/cyclonedx-python-lib
2 participants
@jkowalleck @madpah