Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Change Formulation and ModelCard schemas to use pointers #79

Open
mrutkows opened this issue Apr 1, 2024 · 0 comments
Open

TODO: Change Formulation and ModelCard schemas to use pointers #79

mrutkows opened this issue Apr 1, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mrutkows
Copy link
Contributor

mrutkows commented Apr 1, 2024 •
edited

The CycloneDX schema file:

/Users/Matt_1/Projects/CycloneDX/sbom-utility/schema/cyclonedx_formulation.go

defines all the structures used for "formulation" which was added in v1.5; however, these structs should be updated to use pointers to structs in all cases to improve performance during JSON Marshal (decoding).

The same should be done for the added ModelCard data (as part of the Component type):

/Users/Matt_1/Projects/CycloneDX/sbom-utility/schema/cyclonedx_modelcard.go
@mrutkows mrutkows added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 1, 2024
@mrutkows mrutkows changed the title TODO: Change Formulation schema to use pointers TODO: Change Formulation and ModelCard schemas to use pointers Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrutkows