Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the dns message id to 0 for doh requests #65

Open
VanStratum opened this issue Apr 22, 2021 · 2 comments
Open

Set the dns message id to 0 for doh requests #65

VanStratum opened this issue Apr 22, 2021 · 2 comments

Comments

@VanStratum
Copy link
Contributor

VanStratum commented Apr 22, 2021

The doh rfc says in section 4.1 that the dns messages ids should be set to 0 to be more cache friendly. This could be useful when testing caching doh servers, or servers behind a http cache.

This would however necessitate changing the message tracking method.

@weyrick
Copy link
Contributor

weyrick commented Apr 26, 2021

Interesting, ok perhaps we could switch to an internal id for tracking, based on a quick hash of some properties in the message.

@VanStratum
Copy link
Contributor Author

I ran in a similar issue with DoQ, where the stream id identifies the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants