Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 breaking changes tracking issue #1585

Open
akiraveliara opened this issue Jul 6, 2023 · 16 comments
Open

v5 breaking changes tracking issue #1585

akiraveliara opened this issue Jul 6, 2023 · 16 comments
Milestone

Comments

@akiraveliara
Copy link
Contributor

akiraveliara commented Jul 6, 2023

every breaking change should be listed in the issue comments so we don't miss anything for the migration guide

@akiraveliara akiraveliara pinned this issue Jul 6, 2023
@akiraveliara
Copy link
Contributor Author

akiraveliara commented Jul 6, 2023

#1584 - renamed Ready to SessionCreated, Resumed to SessionResumed and ReadyEventArgs to SessionReadyEventArgs

@DubyaDude
Copy link
Contributor

#1610 - Renamed Discord Intents GuildEmojis to GuildEmojisAndStickers, GuildBans to GuildModeration

@akiraveliara
Copy link
Contributor Author

#1616 removed user tokens and miscellaneous removed API fields

@Plerx2493
Copy link
Member

Plerx2493 commented Sep 12, 2023

#1612 - DiscordGuild#GetAuditLog returns now a IAsyncEnumerable

@Plerx2493
Copy link
Member

#1618 - All auditlog specific classes moved to DSharpPlus.Entities.AuditLogs

@Plerx2493
Copy link
Member

#1619 - DiscordShardedClient events were updated to mirror the DiscordClient

@akiraveliara akiraveliara added this to the v5.0 milestone Oct 5, 2023
@akiraveliara akiraveliara removed the v5.x label Oct 5, 2023
@Plerx2493
Copy link
Member

Plerx2493 commented Oct 7, 2023

#1641 - DiscordChannel#GetMessages*Async returns now a IAsyncEnumerable

@Plerx2493
Copy link
Member

Plerx2493 commented Oct 7, 2023

#1644 - DiscordGuild#GetAllMembersAsync and DiscordGuild#GetEventUsersAsync return now a IAsyncEnumerable

@Plerx2493
Copy link
Member

#1668 - MessageAcknowledged Event removed (deprecated)

@akiraveliara
Copy link
Contributor Author

akiraveliara commented Nov 10, 2023

enums being moved to DSharpPlus.Entities and renamed to Discord* - #1672 #1673 #1674 and more, edit when more are merged

@akiraveliara
Copy link
Contributor Author

#1742 broke the naming of MessageFlags.SupressEmbeds to fix the spelling error

@Plerx2493
Copy link
Member

Plerx2493 commented Feb 13, 2024

#1764 - Removal of DiscordConfiguration#UseRelativeRatelimits (Ratelimits are now always relative like the old default)

@akiraveliara
Copy link
Contributor Author

#1844 - broke just about every bot with enum naming

@Plerx2493
Copy link
Member

Plerx2493 commented May 2, 2024

#1869 - Banning a user now takes a TimeSpan for the message deletion and uses the delete_message_seconds parameter in the api call

@Plerx2493
Copy link
Member

#1881 - Replaces the existing DiscordGuild#GetChannel with GetChannelAsync which now also does api calls if the requested channel is not in cache. Also multiple fields which relied only on channels beeing in cache were replaced with methods which uses the new implementation:

  • DiscordGuild.AfkChannel -> DiscordGuild.GetAfkChannelAsync
  • DiscordGuild.SystemChannel -> DiscordGuild.GetSystemChannelAsync
  • DiscordGuild.SafetyAlertsChannel -> DiscordGuild.GetSafetyAlertsChannelAsync
  • DiscordGuild.WidgetChannel -> DiscordGuild.GetWidgetChannelAsync
  • DiscordGuild.RulesChannel -> DiscordGuild.GetRulesChannelAsync
  • DiscordGuild.PublicUpdatesChannel -> DiscordGuild.GetPublicUpdatesChannelAsync

Also the ids of those channels were made public

@Plerx2493
Copy link
Member

#1894 - DiscordGuild#AddMemberAsync was updated to reflect api changes. The api takes Snowflakes instead of DiscordRole instances, therefore we added DiscordGuild#AddMemberWithRolesAsync with several overloads to dodge ambiguous matches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants