Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental source generation support in commands #1591

Open
itsWindows11 opened this issue Jul 9, 2023 · 5 comments
Open

Incremental source generation support in commands #1591

itsWindows11 opened this issue Jul 9, 2023 · 5 comments
Labels
big-change core enhancement new-features on-hold performance (v6) indicates a performance issue
Milestone
v6.0

Comments

@itsWindows11
Copy link

Has anyone considered adding source generation support for DSharpPlus.SlashCommands and DSharpPlus.CommandsNext? That could help make it more AOT compatible and can improve performance.
@InFTord
Copy link
Member

InFTord commented Jul 9, 2023

both cnext and slashies are probably gonna be deprecated/removed in v5 and replaced with a new command framework

@itsWindows11
Copy link
Author

itsWindows11 commented Jul 9, 2023 •
edited

I see, dunno if it's planned (the source generation support) so will keep this issue open just in case.

@OoLunar
Copy link
Member

OoLunar commented Jul 9, 2023

It's been debated off and on for v6, however v5 has no plans to include any source generation. If you wish to collaborate with us to add sgen, I would go to @akiraveliara since she is currently the one who has worked the most on v6.

@akiraveliara
Copy link
Contributor

* worth noting that i will not oppose sgen for commands in v5

@OoLunar
Copy link
Member

OoLunar commented Jul 9, 2023

I will though!

@akiraveliara akiraveliara added this to the v6.0 milestone Oct 5, 2023
@akiraveliara akiraveliara changed the title Incremental source generation support Incremental source generation support in commands Oct 5, 2023
@akiraveliara akiraveliara removed the v6.x label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
big-change core enhancement new-features on-hold performance (v6) indicates a performance issue
Projects
None yet
Milestone
v6.0
Development

No branches or pull requests
4 participants
@OoLunar @InFTord @akiraveliara @itsWindows11