Add support for Windows CE browsers #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karpour this looks good to me - happy to add support for those browsers. Prior to merging this in could you remove the |
Merged
|
Should be good now, package-lock.json is gone. |
|
@DamonOehlman I merged with master and resolved conflicts. |
|
@karpour - awesome - merging it in. |
|
And published as |
klarstrup
reviewed
Dec 5, 2021
Comment on lines
+157
to
+159
| ['pie',/^Microsoft Pocket Internet Explorer\/(\d+\.\d+)$/], | ||
| ['pie',/^Mozilla\/\d\.\d+\s\(compatible;\s(?:MSP?IE|MSInternet Explorer) (\d+\.\d+);.*Windows CE.*\)$/], | ||
| ['netfront',/^Mozilla\/\d\.\d+.*NetFront\/(\d.\d)/], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows CE remains used to this day on legacy systems, so adding support for these browsers still makes sense. This PR adds support for all versions of Pocket Internet Explorer, which is included in the ROM of pretty much every Windows CE device, as well as the Japanese NetFront browser, which was also popular on Windows CE, among other portable devices and game consoles.
User Agents used for testing:
Microsoft Pocket Internet Explorer/0.6
Mozilla/1.1 (compatible; MSPIE 1.1; Windows CE)
Mozilla/1.1 (compatible; MSPIE 2.0; Windows CE)
Mozilla/2.0 (compatible; MSIE 3.02; Windows CE)
Mozilla/4.0 (compatible; MSIE 4.01; Windows CE)
Mozilla/4.0 (compatible; MSIE 4.01; Windows NT Windows CE)
Mozilla/4.0 (compatible; MSIE 4.01; Windows NT Windows CE; 800x480)
Mozilla/4.0 (compatible; MSIE 5.5; Windows CE)
Mozilla/4.0 (compatible; MSIE 6.0; Windows CE)
Mozilla/2.0 (compatible; MSInternet Explorer 3.02; Windows CE; 240x320)
Mozilla/2.0 (compatible; MSIE 3.02; Windows CE; 240x320)
Mozilla/2.0 (compatible; MSIE 3.02; Windows CE; PPC; javascript; 240x320)
Mozilla/2.0 (compatible; MSIE 3.02; Windows CE; PPC; 240x320)
Mozilla/4.0 (PDA; Windows CE;1.0.0) NetFront/3.0
Mozilla/4.08 (PDA; Windows CE;1.0.0) NetFront/3.1
Mozilla/4.0 (compatible; MSIE 4.01; Windows CE; PPC; 240x320)
Mozilla/2.0 (compatible; MSIE 3.02; Windows CE; Smartphone; javascript; *)
Mozilla/2.0 (compatible; MSIE 3.02; Windows CE; Smartphone; 176x220)
Mozilla/2.0 (compatible; MSIE 3.02; Windows CE; Smartphone; *)
Mozilla/4.0 (compatible; MSIE 4.01; Windows CE; Smartphone; 176x220; SPV C500; OpVer 4.1.1.0)
Mozilla/4.0 (compatible; MSIE 4.01; Windows CE; Smartphone; 176x220; SPV C500; OpVer 4.1.3.0)
Mozilla/4.0 (PDA; Windows CE;0.9.3) NetFront/3.0
Mozilla/4.0 (PDA; Windows CE;1.0.1) NetFront/3.0