Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider including a "family" field #99

Open
DamonOehlman opened this issue Apr 8, 2019 · 3 comments
Open

Consider including a "family" field #99

DamonOehlman opened this issue Apr 8, 2019 · 3 comments

Comments

@DamonOehlman
Copy link
Owner

With a lot of chrome-like browsers available on Android phones, and the fact that detect-browser evolves to identify more of them (PR #98 as an example) I think we are heading to the point where a general 'family' field might be of use in the result data.

This would open up the possibility of having logic (note pseudo code) that would allow for the following:

if (specificBrowserA) {
 ...
} else if (browserFamilyA) {
 ...
} else {
 ...
}

Using logic like the above a developer could specify special treatment for a very specific browser (e.g. Miui) but other Chromium based browsers to be handled another (with a fairly minimal amount of code).

@mungojam
Copy link

This will become important for us when the chromium based Edge starts to appear widely because it can probably be treated the same as Chrome in most cases

@mungojam
Copy link

just seen that you have edge-chromium as a specific entry already, so it isn't so important

@max-programming
Copy link

I think it is good to remove the edge entry now because Edge Chromium is now known as the standard Edge browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants