Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use single runtime chunk will cause error #56

Open
Austaras opened this issue Jan 11, 2020 · 3 comments · Fixed by #65
Open

use single runtime chunk will cause error #56

Austaras opened this issue Jan 11, 2020 · 3 comments · Fixed by #65
Labels

Comments

@Austaras
Copy link
Contributor

Austaras commented Jan 11, 2020

set webpack config

optimization: {
    runtimeChunk: 'single',
}

will cause
ERROR in TypeError: Cannot read property 'options' of undefined

@Austaras
Copy link
Contributor Author

Austaras commented Jan 7, 2021

This is not fixed, it will cause vendor.js loaded in both preset. @DanielSchaffer can you reopen this?

@DanielSchaffer
Copy link
Owner

In this scenario, does the vendor.js have mixed ES levels? It might be possible that if the stuff that gets put into the vendor chunk is already ES5 / "legacy" compatible, it could just use that for both bundles.

@Austaras
Copy link
Contributor Author

No. I tested it with typescript-plain which should generate a vendor.js with only core-js and regenerator-runtime, it should never be loaded in modern target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants