Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang (infinite loop, CPU 100%) if the manifest's PSSH tag contains whitespace #3260

Closed
5 tasks done
elv-peter opened this issue May 21, 2020 · 2 comments
Closed
5 tasks done
Assignees
Milestone

Comments

@elv-peter
Copy link

elv-peter commented May 21, 2020

Environment
Steps to reproduce

dash.js hangs if the pssh tag in the manifest has spaces or newlines

good:

<cenc:pssh>AAAANHBzc2gAAAAA7e+LqXnWSs6jyCfc1R0h7QAAABQIARABGgZlbHV2aW8iBmVsdXZpbw==</cenc:pssh>

dash.js hangs forever:

<cenc:pssh>
    AAAANHBzc2gAAAAA7e+LqXnWSs6jyCfc1R0h7QAAABQIARABGgZlbHV2aW8iBmVsdXZpbw==
</cenc:pssh>
Observed behaviour

parsePSSHList in streaming.protection.CommonEncryption never breaks out of its loop because it reads size as 0

Console output

N/A

@dsilhavy dsilhavy added this to the 3.1.2 milestone May 23, 2020
@dsilhavy dsilhavy self-assigned this May 23, 2020
@dsilhavy
Copy link
Collaborator

Please check if #3262 solves your issue. See nightly build (version 3.1.2):
http://reference.dashif.org/dash.js/nightly/samples/dash-if-reference-player/index.html

@elv-peter
Copy link
Author

Fixed! Thank you!

I found out that whitespace is significant in XML, so it was avoidable on my part. But sanitizing the XML is still good where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants