Modify Offline module API #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 3, 2020 15:44
- access offline module using MediaPlayer.getOfflineController()
- modify OfflineController API ("record" instead of "download")
- inject dependencies when creating OfflineController
- use MediaInfo type to get and select the available tracks representations to record/download
- add offline module types in index.d.ts
- update jsdoc
- update sample
- store original manifest as a string in indexedDB instead of full object (can lead to DataCloneError) - use DashParser to parse stored manifest when loading/resuming download of a record
(cherry picked from commit 5e6b73e)
dsilhavy
reviewed
Jun 8, 2020
| @@ -1028,23 +1027,23 @@ app.controller('DashController', function ($scope, $timeout, $q, sources, contri | |||
| // | |||
| //////////////////////////////////////// | |||
|
|
|||
| @@ -5,45 +5,46 @@ angular.module('DashPlayer'). | |||
| service('DownloadService', function () { | |||
|
|
|||
| player = undefined; | |||
| var downloads = []; | |||
| offlineController = undefined; | |||
There was a problem hiding this comment.
Define variables offlineController and player or should they be in global scope
There was a problem hiding this comment.
Yes offlineController can be removed from global scope since we can get it from player
|
@bbert I checked functionality regarding download of video, audio and texttracks. Looks good to me, just added two minor comments above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the Offline module API in order to access offline module using
MediaPlayer.getOfflineController()Types have been declared in index.d.ts to resolve issue #3261
JSDoc has also been fixed