Fix regression for representationInfo's segmentDuration #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 11, 2020 10:52
…fo (for example for SegmentTimeline, not set in manifest)
…fo (for example for SegmentTimeline, not set in manifest)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in v3.0.
Since v3.0, segments info lists are no more pre-computed, each segment info is now computed when requesting a segment.
As a consequence, segment duration for any representation is not set until a media segment is requested.
Since segmentDuration may be used prior to any media segment request (for example buffer target calculation for text tracks, or segment availability range computation), this leads to some dysfunction (for example text track switching for streams with SegmentTimeline).