Store and use fragmentedText settings in localStorage #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omStorage, initial settings...)
…omStorage, initial settings...)
jeffcunat
force-pushed
the
textSettingsInLocalStorage
branch
from
968b4af
to
f7b2f6f
Compare
dsilhavy
reviewed
Jul 14, 2020
dsilhavy
reviewed
Jul 14, 2020
dsilhavy
reviewed
Jul 14, 2020
dsilhavy
reviewed
Jul 14, 2020
dsilhavy
reviewed
Jul 14, 2020
dsilhavy
reviewed
Jul 14, 2020
dsilhavy
reviewed
Jul 14, 2020
dsilhavy
reviewed
Jul 14, 2020
| @@ -282,6 +302,9 @@ function TextController() { | |||
|
|
|||
| let oldTrackIdx = textTracks.getCurrentTrackIdx(); | |||
| if (oldTrackIdx !== idx) { | |||
| if (allTracksAreDisabled && mediaController) { | |||
| mediaController.saveTextSettingsDisabled(); | |||
There was a problem hiding this comment.
Can we use mediaController.setTrack here instead of saveTextSettingsDisabled?
There was a problem hiding this comment.
That would complexify mediaController.setTrack
added 4 commits
July 15, 2020 08:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fragmentedText initial settings were already stored in localStorage but never used.
This PR allows to reuse previous subtitles settings stored in localStorage.
They are only used when loading a stream if
This means that, if no other settings are set, dash.js player will reuse previously used subtitles language/role when loading a new stream (like what is already done for audio content)
samples/captioning/multi-track-captions.html has been modified in order to test various settings combination (no more auto-load to be able to set settings before loading)