Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exitFullscreen -> fullscreenElement #3296

Merged

Conversation

ashutoshsingh0223
Copy link
Contributor

  • document.exitFullscreen -> document.fullscreenElement in exitFullscreen.
  • document.exitFullscreen throws TypeError: Document not active on exitFullscreen

document.exitFullscreen ->  document.fullscreenElement in exitFullscreen.
@dsilhavy
Copy link
Collaborator

@ashutoshsingh0223 Thanks for this PR. Following our contribution guidelines, and given this is your first PR, could you please send to me a signed copy of dash.js feedback agreement?

Thanks

@ashutoshsingh0223
Copy link
Contributor Author

ashutoshsingh0223 commented Jun 19, 2020 via email

@ashutoshsingh0223
Copy link
Contributor Author

https://ott-admin.s3.ap-south-1.amazonaws.com/DASH-IF-Feedback-Agreement-3-7-2014.pdf

@ashutoshsingh0223
Copy link
Contributor Author

@dsilhavy How do I merge this? Can you help?

@dsilhavy
Copy link
Collaborator

Hi please add the old functionality in else as well:

  if (!document.fullscreenElement) {
     document.exitFullscreen();
  } else {
        if (document.exitFullscreen) {
           document.exitFullscreen(); 
       }
  }

I will merge afterwards
Thanks

@dsilhavy dsilhavy added this to the 3.1.2 milestone Jun 24, 2020
@dsilhavy dsilhavy self-assigned this Jun 24, 2020
@dsilhavy dsilhavy merged commit fe337f9 into Dash-Industry-Forum:development Jun 24, 2020
jeffcunat pushed a commit to Orange-OpenSource/dash.js that referenced this pull request Jul 6, 2020
* exitFullscreen ->  fullscreenElement

document.exitFullscreen ->  document.fullscreenElement in exitFullscreen.

* Add old `exitFullscreen` functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants