Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thumbnails API #3297

Merged

Conversation

jeremco
Copy link
Contributor

@jeremco jeremco commented Jun 17, 2020

Hi all

This PR make some improvements on thumbnails API.

  • Update index.d.ts file

  • Rename getThumbnail by provideThumbnail : In some cases (SegmentBase for example), thumbnails are get in a asynchrounous way using callback. In some other cases, thumbnails are get in a synchronous way, using return of function. To uniformize the behaviour, thumbnails are always provided using a callback.

  • Display thumbnails bitrate list in control bar (to test the fact we can choose thumbnails representation)

Jérémie

- Update index.d.ts file

- Rename getThumbnail by provideThumbnail : In some cases (SegmentBase for images), thumbnails getting is asynchronous and is get using callback. To uniformize the behaviour, thubnails are always provided using a callback.

- Display thumbnails bitrate list in control bar
@dsilhavy dsilhavy added this to the 3.1.2 milestone Jun 17, 2020
@dsilhavy dsilhavy self-requested a review June 17, 2020 14:26
@dsilhavy dsilhavy merged commit a700684 into Dash-Industry-Forum:development Jun 18, 2020
jeffcunat pushed a commit to Orange-OpenSource/dash.js that referenced this pull request Jul 6, 2020
* Thumbnails Improvments :

- Update index.d.ts file

- Rename getThumbnail by provideThumbnail : In some cases (SegmentBase for images), thumbnails getting is asynchronous and is get using callback. To uniformize the behaviour, thubnails are always provided using a callback.

- Display thumbnails bitrate list in control bar

* For IE11 and some others old browsers, the verification of autoswitch parameter is done in function

* Verificy that callback parameter is a function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants