Fix multiperiod representation update #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he playback controller. This allows us to consider the current playback position for multiperiod streams.
… use playback controller and schedule controller to determine current period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to consider multiperiod manifests when updating the representations in the RepresentationController. The update of the Representations is postponed whenever live delay is larger than availwindow.end - availwindow.start.
However, for multiperiod we might still be playing in the previous period when a new period is introduced and the respective RepresentationController updates the representations. Live delay might be too large so we need to consider the currently playing period as starttime anchor: Math.min(availwindow.start,currenttime)