Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Add documentation for ThroughputRule #4371

Closed
dsilhavy opened this issue Jan 25, 2024 · 2 comments
Closed

Documentation: Add documentation for ThroughputRule #4371

dsilhavy opened this issue Jan 25, 2024 · 2 comments
Assignees
@dsilhavy
Labels
Documentation Feature Request
Milestone
5.0.0

Comments

@dsilhavy
Copy link
Collaborator

Description

The ABR section of our new documentation page should contain information about the ThroughputRule. As part of this issue the plan is to revisit the concrete implementation of ThroughputRule.js and possibly refactor the code if required.
@dsilhavy dsilhavy added this to the 5.0.0 milestone Jan 25, 2024
@dsilhavy dsilhavy self-assigned this Jan 25, 2024
@dsilhavy
Copy link
Collaborator Author

Implemented in b2f58d7

@janev94
Copy link

janev94 commented Apr 16, 2024

Throughput Calculation and description of abrThroughput does not mention latency as an input parameter. Current dash.js implementation uses latencyInMs to aid the estimated throughput calculation. I found an instance where this might lead to non-intuitive behaviour and explained it in #4455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsilhavy dsilhavy

Labels
Documentation Feature Request
Projects
dash.js Version 5.0.0
Status: Done
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@janev94 @dsilhavy