Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dash.js player doesn't seem to work if 'Location' field in manifest file is different from the manifest download uri. #4386

Open
JPDelprat opened this issue Feb 11, 2024 · 4 comments
Milestone

Comments

@JPDelprat
Copy link

JPDelprat commented Feb 11, 2024

Version 4.7.4
Problem with reference online player.

dash.js player doesn't seem to work if 'Location' field in manifest file is different from the manifest download uri.

Bug seems to be located in the following method.

function getBaseURLsFromElement(node) {
var entries = node.BaseURL_asArray || [node.baseUri];

This method doesn't take manifest 'Location' field into account.

This method is called recursively on manifest nodes.

I've fixed it by replacing

var entries = node.BaseURL_asArray || [node.baseUri];
with
var entries = node.Location_asArray || node.BaseURL_asArray || [node.baseUri];

I don't know if this is the correct fix, but this may help you to solve the problem.

@JPDelprat JPDelprat added the Bug label Feb 11, 2024
@JPDelprat JPDelprat changed the title dash.js player doesn't seem to work if 'Location' in manifest file is different from the manifest download uri. dash.js player doesn't seem to work if 'Location' field in manifest file is different from the manifest download uri. Feb 11, 2024
@dsilhavy
Copy link
Collaborator

Can you provide a sample stream to reproduce?

@JPDelprat
Copy link
Author

JPDelprat commented Feb 13, 2024

Hello,

Please find attached a sample stream.

Test.zip

This is a just of modified version of https://dash.akamaized.net/akamai/bbb_30fps/bbb_30fps.mpd :

  • added 'Location' section at the beginning (line 3)
  • commented out 'BaseUrl' just in case (line 2)

You can see the problem:

'Location' should allow to view the stream at the provided 'Location' (https://dash.akamaized.net/akamai/bbb_30fps/bbb_30fps.mpd).

Instead, the player try to read steam relatively to the manifest place (from disk).

With my modified version of your player, it works. See my first post, but I'm not sure at all this the correct fix.

Regards

@davemevans
Copy link
Contributor

Related: #1887

@JPDelprat
Copy link
Author

Hi, dsilhavy

Did you manage to reproduce the bug with my sample ?

Thanks

@dsilhavy dsilhavy added this to the 5.0.0 milestone Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants