Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EssentialProperties: allow schemeIdUri+value pairs #4405

Closed
stschr opened this issue Mar 5, 2024 · 2 comments
Closed

EssentialProperties: allow schemeIdUri+value pairs #4405

stschr opened this issue Mar 5, 2024 · 2 comments
Assignees
Milestone

Comments

@stschr
Copy link
Contributor

stschr commented Mar 5, 2024

To follow up on #4384 and enhance #4385

We think it's a good idea to enable setting pairs of @schemeIdUri + values as known essentialProperties.

To enable this, I have two options available:

  1. add a second item supportedEssentialPropertySchemeValues to Settings.js;
capabilities: {
    filterUnsupportedEssentialProperties: true,
    supportedEssentialProperties: [Constants.FONT_DOWNLOAD_DVB_SCHEME, ...Constants.THUMBNAILS_SCHEME_ID_URIS],
    supportedEssentialPropertySchemeValues: [...Constants.SCHEME_ID_URI_SDR],
    useMediaCapabilitiesApi: false
},

with (in Constants.js)

SCHEME_ID_URI_SDR: [
        {schemeIdUri: 'urn:mpeg:mpegB:cicp:ColourPrimaries', value: '5'}
],

  1. enhance supportedEssentialProperties with @value which can utilize RegEx, similar to this:
capabilities: {
    filterUnsupportedEssentialProperties: true,
    supportedEssentialProperties: [Constants.ESSENTIAL_PROP_SCHEME],
    useMediaCapabilitiesApi: false
}

ESSENTIAL_PROP_SCHEME: [
        {schemeIdUri: 'urn:mpeg:mpegB:cicp:ColourPrimaries', value: '5'},
        {schemeIdUri: 'urn:dvb:dash:fontdownload:2014', value: /.*/ }
]

From my point of view, I prefer the 2nd approach using RegEx as this utilizes only one data field in settings, however it implies an incompatibility with v4.

@dsilhavy : Please advise! I'll follow up with full code as PR

@stschr stschr self-assigned this Mar 5, 2024
@stschr stschr added this to the 5.0.0 milestone Mar 5, 2024
@dsilhavy
Copy link
Collaborator

The 2nd approach sounds much more reasonable thanks. Related pull request with further discussion: #4411

@stschr
Copy link
Contributor Author

stschr commented Mar 15, 2024

Resolved by: #4411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants