You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
currently we're not process the up coming flow when manifest changes from dynamic to static.
time and duration calculations totally based on isDynamic
based on 1, it's ok to still calculate time and duration with dynamic
After above pr merged
when we call the time method, isDynamic will return false to us, so we'll not reduce the dvr.start, which leads to a wrong current time.
// we'll not run into this code segmentt=(metric===null||t===0) ? 0 : Math.max(0,(t-metric.range.start));returnt;
when we call the duration method, we'll return videoElement.duration which is still Infinity.
letd=getVideoElement().duration;if(playbackController.getIsDynamic()){// we'll not run into this code segment anymore.consttype=streamController&&streamController.hasVideoTrack() ? Constants.VIDEO : Constants.AUDIO;letmetric=dashMetrics.getCurrentDVRInfo(type);d=metric ? (metric.range.end-metric.range.start) : 0;}returnd;
The text was updated successfully, but these errors were encountered:
KunXi-Fox
changed the title
Current Time and Duration not correct on v4.7.3
Current Time and Duration not correct after live ended on v4.7.3
Apr 28, 2024
Environment
Steps to reproduce
watch a live event and wait for it's end
Observed behavior
the current time is much larger than duration
Console output
dashInstance.time()
dashInstance.duration()
dashInstance.duration()
for last dynamic manifestMore information
The issue introduced by this PR
As far as we know
dynamic
tostatic
.time
andduration
calculations totally based onisDynamic
time
andduration
withdynamic
After above pr merged
time
method,isDynamic
will return false to us, so we'll not reduce the dvr.start, which leads to a wrong current time.duration
method, we'll returnvideoElement.duration
which is stillInfinity
.The text was updated successfully, but these errors were encountered: