Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using fetch as http client doesn't add trace_id & span_id as Headers #2178

Open
vigohe opened this issue Jul 13, 2022 · 2 comments
Open

using fetch as http client doesn't add trace_id & span_id as Headers #2178

vigohe opened this issue Jul 13, 2022 · 2 comments

Comments

@vigohe
Copy link

vigohe commented Jul 13, 2022

Expected behaviour
When fetch it's execute should add trace_id & span_id automatically as Headers

Actual behaviour
When checking a trace between two services no dependency exists because the trace_id & span_id are missing

Steps to reproduce
fetch("http://example.com");

Environment docker

  • Operation system: docker image node:18-alpine
  • Node.js version: node 18
  • Tracer version: 2.10.0
  • Agent version: 7.37.1
@vigohe vigohe added the bug Something isn't working label Jul 13, 2022
@rochdev
Copy link
Member

rochdev commented Jul 13, 2022

Changing this to a feature request since the reason this doesn't work is that fetch is not supported yet so we don't have an integration for it.

@rochdev rochdev added feature-request and removed bug Something isn't working labels Jul 13, 2022
@pinko-fowle
Copy link

pinko-fowle commented Jan 9, 2023

There is some work in progress from back in April in #2010.

Node 18.13.0 just shipped fetch without the experimental warning. The PR for that is nodejs/node#45287.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants