Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex matching doesn't account for case insensitivity pattern #3245

Closed
tommyksander opened this issue Jun 14, 2023 · 0 comments · Fixed by #3301
Closed

Regex matching doesn't account for case insensitivity pattern #3245

tommyksander opened this issue Jun 14, 2023 · 0 comments · Fixed by #3301
Labels
bug Something isn't working integration-express

Comments

@tommyksander
Copy link

Note: This issue is related to recent work on:

Expected behaviour

  • dd-trace should handle app.use regex strings that include case insensitivity. E.g., (/^\/(?!sample\/route).*/i)

Actual behaviour

  • dd-trace doesn't identify this regex pattern, so the bug fixed in <> still exists for patterns that include case insensitivity. (code)

Steps to reproduce

  • Add app.use that includes a regex with case insensitivity E.g., (/^\/(?!sample\/route).*/i)
  • Run dd-trace to see routes are lost.
  • Probably easiest to add this case in the unit tests and run it there: packages/datadog-plugin-express/test/index.spec.js

Environment

  • Operation system:
  • Node.js version:
  • Tracer version:
  • Agent version:
  • Relevant library versions:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integration-express
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants