-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous profiling not working with NextJS instrumentation #4243
Comments
Hey, after some debugging we found that the issue was that Have created a upstream fix here awaiting merge. Tagging maintainers as this is an actual bug that will prevent nextjs |
Thank you for the upstream fix! Do you think this could be done in a more generic way? We have more native extensions than just profiling and we have more coming as well. Having to remember to update a list in an external project, while doable, is definitely not ideal. |
To be honest, I'm not sure if this is a unique case because vercel has their own tree-shaking logic for For this specific case, the most intuitive DX I could imagine that would not require too many changes on Then, your team could add some specific code snippets for users to include in This seems to be the best middleground without sprinkling moar AST magic 🧙 into their code haha (if you are interested, can have a look at vercel/nft#392, which was a fix for another module, this involved just hardcoding another way to handle imports which banked on the fact that Hope this makes sense! |
Getting no profiles in the APM section after setting the following configs to tracer on NextJS.
Could I check if this is a bug or I have to enable something else on my end? Thank you.
The text was updated successfully, but these errors were encountered: