-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Laravel Octane traces not showing in dashboard #2636
Comments
Hello 👋 Do you know if the Trace agent is receiving the traces at all? You can see that by either checking the datadog-agent status, or by looking at the Trace Agent dashboard on the Datadig UI for your corresponding service. Thanks! |
@PROFeNoM The agent is definitely working, there are other services still reporting traces within that cluster. There are other operation traces coming from those service pods but not
|
Hi @s1rc, I can reproduce it to keep you updated, but I may have found the root cause. I'm working on a fix/Figuring out the best course of action. I wanted to know: Was there any particular reason you disabled DD_INSTRUMENTATION_TELEMETRY_ENABLED? |
@PROFeNoM awesome, if there's any way I can help let me know. Re: |
Right, okay. Thanks for letting me know @s1rc 😃 Please try enabling DD_TRACE_SIDECAR_TRACE_SENDER. I started an environment from scratch this morning and reproduced the issue. After trying multiple combinations, enabling this feature fixed the problem. However, I'm still trying to figure out the exact root cause. Technically, it will send the traces through the sidecar. That's why I was asking about DD_INSTRUMENTATION_TELEMETRY_ENABLED, as telemetry also makes use of the sidecar, and I wanted to make sure there weren't any technical limitations :) |
@PROFeNoM I tried adding Interesting thing, I notice that now I am seeing traces for |
Hi @s1rc 👋 Thanks for your patience. An issue was attempted to be fixed with #2645. Could you please try out the following artifact (CircleCI Job)? To use the artifact, if you followed the public doc, then you have to replace the link you were using to download the Just so you know, I was using the following app to do my tests. |
Hi @PROFeNoM, did some tests using your repository and got the same results called a few times (100+) the simple endpoint, simple_view and nothing... |
Hey @sneycampos, in the service catalog, can you please look for |
Ok, now i see :D, there's any way to set web.request as primary operation? laravel.request doesn't see useful for us (customer) i think Now i'll try to figure out how to work in my application (using alpine images) a few minutes before trying your repository i tried with my app using openswoole/swoole:22.1.1-php8.3-alpine image, installed libgcc but doesn't see any web.request |
@sneycampos I don't think OpenSwoole is supported re: #704 (comment) Also, from the service page click on "Service Info" top right corner. There is a tab "Primary Operation". |
Sorry, forgot this message. I will switch to swoole's image and give you a feedback as soon as possible |
Ok, now it works! a great news this working with laravel octane finally 🚀 Hope it is release asap to be used in production Great work @PROFeNoM! |
Thank you @PROFeNoM , so far with that artifact I am seeing traces under the I do have follow up questions:
|
The 1.0 is now out, containing the support for this :-) |
Bug report
We have a k8s deployment where we are turning Laravel Octane on instead of php-fpm. I have added the following
DD_TRACE_CLI_ENABLED: true
to the deployment as per #704 (comment)We are not seeing any traces from testing calls on the server. We do see
artisan config:cache
and the nginx trace, which is configured in front of Laravel Octane.Aside from adding
DD_TRACE_CLI_ENABLED: true
is there anything else we need to do?Here are the configured DD specific ENV variables:
PHP version
8.2.17
Tracer or profiler version
0.99.1
Installed extensions
The text was updated successfully, but these errors were encountered: