Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected TypeError while exporting events #8996

Closed
Andrew-Chen-Wang opened this issue Apr 16, 2024 · 2 comments
Closed

Unexpected TypeError while exporting events #8996

Andrew-Chen-Wang opened this issue Apr 16, 2024 · 2 comments
Assignees
@P403n1x87
Labels
Profiling Continous Profling

Comments

@Andrew-Chen-Wang
Copy link

Andrew-Chen-Wang commented Apr 16, 2024 •
edited

Summary of problem

Error occurred in DD

Which version of dd-trace-py are you using?

ddtrace = "^2.0.0"

from our poetry.lock file

Which version of pip are you using?

not sure; production system

Which libraries and their versions are you using?

`pip freeze`

How can we reproduce your problem?

unsure, we're seeing Unexpected error while exporting events. Please report this bug to https://github.com/DataDog/dd-trace-py/issues

What is the result that you get?

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/ddtrace/profiling/scheduler.py", line 65, in flush
    exp.export(events, start, self._last_export)
  File "/usr/local/lib/python3.10/site-packages/ddtrace/profiling/exporter/http.py", line 218, in export
    "tags_profiler": self._get_tags(service),
  File "/usr/local/lib/python3.10/site-packages/ddtrace/profiling/exporter/http.py", line 155, in _get_tags
    return ",".join(tag + ":" + value for tag, value in tags.items())
  File "/usr/local/lib/python3.10/site-packages/ddtrace/profiling/exporter/http.py", line 155, in <genexpr>
    return ",".join(tag + ":" + value for tag, value in tags.items())
TypeError: can only concatenate str (not "int") to str

What is the result that you expected?

No error
@gnufede gnufede added the Profiling Continous Profling label Apr 16, 2024
@sanchda sanchda self-assigned this Apr 16, 2024
@P403n1x87 P403n1x87 mentioned this issue Apr 18, 2024
Merged
17 tasks
@emmettbutler emmettbutler assigned P403n1x87 and unassigned sanchda Apr 18, 2024
P403n1x87 added a commit that referenced this issue Apr 18, 2024
@P403n1x87
fix(profiling): HTTP exporter tag serialisation (#9032)
0bacde0 
Ensure that the HTTP exporter does not fail to serialise the tags.

Addresses #8996.

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Description motivates each change
- [ ] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Release note makes sense to a user of the library
- [ ] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
github-actions bot pushed a commit that referenced this issue Apr 18, 2024
@P403n1x87 @github-actions
fix(profiling): HTTP exporter tag serialisation (#9032)
bbc9c19 
Ensure that the HTTP exporter does not fail to serialise the tags.

Addresses #8996.

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Description motivates each change
- [ ] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Release note makes sense to a user of the library
- [ ] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 0bacde0)
@github-actions github-actions bot mentioned this issue Apr 18, 2024
Merged
17 tasks
gnufede pushed a commit that referenced this issue Apr 22, 2024
@github-actions @P403n1x87
fix(profiling): tag serialisation in HTTP exporter [backport 2.8] (#9042
7405b83 
)

Backport 0bacde0 from #9032 to 2.8.

Ensure that the HTTP exporter does not fail to serialise the tags.

Addresses #8996.

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com>
@mewc
Copy link

mewc commented May 23, 2024

api key valid?

@Andrew-Chen-Wang
Copy link
Author

I believe #9042 addresses this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@P403n1x87 P403n1x87

Labels
Profiling Continous Profling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gnufede @sanchda @mewc @P403n1x87 @Andrew-Chen-Wang