New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicting Node.js DD_TRACE_AGENT_HOST / DD_AGENT_HOST documentation #15554

Open

pinko-fowle opened this issue Oct 12, 2022 · 2 comments

pinko-fowle commented Oct 12, 2022

Documentation Page

Issue Description

https://docs.datadoghq.com/tracing/trace_collection/dd_libraries/nodejs?tab=containers documents the use of DD_AGENT_HOST

meanwhile https://docs.datadoghq.com/tracing/trace_collection/library_config/nodejs/ and dd-trace-js's docs/API.md document the use of slightly different DD_TRACE_AGENT_HOST.

ideally the documentation for Node.js ought be consistent & comprehensive.

The text was updated successfully, but these errors were encountered:

Author

pinko-fowle commented Oct 12, 2022

For reference, in dd-trace-js:

https://github.com/DataDog/dd-trace-js/blob/94edef76f120389c5f31e0ff4d907342780aaab9/packages/dd-trace/src/profiling/config.js#L62 accepts only DD_AGENT_HOST
https://github.com/DataDog/dd-trace-js/blob/94edef76f120389c5f31e0ff4d907342780aaab9/packages/dd-trace/src/config.js#L75-L76 accepts either DD_AGENT_HOST or DD_TRACE_AGENT_HOST.

Collaborator

kayayarai commented Oct 13, 2022

Hi @pinko-fowle Thanks for raising this. I'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment