Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly replace the node_modules folder in the ignore list #49

Open
bbenoist opened this issue Apr 22, 2021 · 1 comment · May be fixed by #50
Open

Correctly replace the node_modules folder in the ignore list #49

bbenoist opened this issue Apr 22, 2021 · 1 comment · May be fixed by #50

Comments

@bbenoist
Copy link

bbenoist commented Apr 22, 2021 •
edited

This line is preventing me to exclude the common/temp/node_modules directory of my monorepo and any "subproject" node_modules directory 😢

e.g. If I md-magic --path '**/*.md' --ignore 'common/temp/node_modules/**', the tool tries to modify its own examples because it finds it in the common/temp/node_modules directory (which is the global store for every dependency of the monorepo).

Is it possible to replace it with something more robust? Maybe just use !**/node_modules/** (⚠️ if it works)?
bbenoist added a commit to bbenoist/markdown-magic that referenced this issue Apr 22, 2021
@bbenoist
Extends node_modules directory exclusion to cwd subdirectories
1e1439e 
Fixes DavidWells#49
@bbenoist bbenoist linked a pull request Apr 22, 2021 that will close this issue
Open
@robinkaulfuss
Copy link

Hey, why does the speedradar mod not goes. I would pay 250 euros for it

@robinkaulfuss robinkaulfuss mentioned this issue May 12, 2021
Open
tylerbutler pushed a commit to tylerbutler/markdown-magic that referenced this issue Jul 20, 2021
@bbenoist @tylerbutler
PR DavidWells#50: Extends node_modules directory exclusion to cwd sub…
a468096 
…directories

Fixes DavidWells#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extends node_modules directory exclusion to cwd subdirectories bbenoist/markdown-magic
2 participants
@bbenoist @robinkaulfuss