dh-make-golang make should delete vendorized files from the debian/sid branch

[CyrilBrulebois]

With one of my first package that contains some components below vendor/, support for it was quite encouraging:

• debian/copyright gets a Files-Excluded directive
• debian/watch exploits that information, triggering a repack when downloading the source tarball.

Two parts are missing:

• debian/changelog could get a +ds1 automatically.
• the relevant files should be deleted from the debian/sid branch automatically.

I wasn't sure about the last part, but @zhsj seemed to agree that leaving excluded files in the packaging branch is not the desired result.

An example can be obtained with:

dh-make-golang make -type l github.com/nxadm/tail

[CyrilBrulebois]

Complementary task: for this package, I had the upstream/1.4.5 tag automatically created (upstream is now at 1.4.6, but the story would be the same). It would probably be best to prune all relevant files from that upstream branch, and tag upstream/1.4.5+ds1 afterwards.

This was spotted by the test_the_archive test in Salsa's CI pipelines.

[CyrilBrulebois]

Interestingly, the upstream clean-up happened for another package, possibly because that was a snapshot instead of a released version/tag?

$ dh-make-golang make -type l github.com/hinshun/vt10x && golang-github-hinshun-vt10x/ && git show --stat upstream | tail -1
 474 files changed, 201932 deletions(-)

[CyrilBrulebois]

Hopefully the last comment for today, for golang-github-hinshun-vt10x: upstream/0.0_git20180809.d55458d is the upstream tag that was created, while it should probably be upstream/0.0_git20180809.d55458d+ds1, unless we consider we're not actually repacking upstream source (there's no upstream tarball after all), even if we're cleaning files from the Git repository… For golang-github-hinshun-vt10x's initial upload, I think I'll keep +ds1 to reflect the fact we're pruning files.