Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.12.0: add prs between 1.11.0 and 1.11.1 to release notes #3628

Closed
valentijnscholten opened this issue Jan 14, 2021 · 4 comments
Closed

1.12.0: add prs between 1.11.0 and 1.11.1 to release notes #3628

valentijnscholten opened this issue Jan 14, 2021 · 4 comments
Labels
Milestone

Comments

@valentijnscholten
Copy link
Member

All the PRs merged into dev between 1.11.0 and 1.11.1 are not listed by release drafter, so we have to add them manually when releasing.

release-drafter/release-drafter#756

@valentijnscholten valentijnscholten added this to the 1.12.0 milestone Jan 14, 2021
@valentijnscholten
Copy link
Member Author

valentijnscholten commented Jan 23, 2021

I created a fork of the release draftw with intention of fixing the behaviour, but it's not so easy because the release draft has lots of different scenario's it supports (except ours).
For now, I have added a second release drafter workflow that can be triggered manually and performs the behaviour we want. But we have to specify the pervious version so it knows which pull requests to list in the changelog.
This must be run on master after the release was merged.

image

image

You can also run it on dev to try it out. fyi @madchap

@madchap
Copy link
Collaborator

madchap commented Jan 25, 2021

So to not get that wrong, tomorrow, the first field would read 1.12.0 (or maybe remain empty?) and the previous release 1.11.0 ?

@valentijnscholten
Copy link
Member Author

Yes, should list all prs front 29/12 onwards

@valentijnscholten
Copy link
Member Author

updated the release instructions, so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants