From f0cc246703f8d8880e8008df9cc852aa48bd3856 Mon Sep 17 00:00:00 2001 From: Spencer Tuft Date: Mon, 9 Oct 2023 11:25:01 -0600 Subject: [PATCH] =?UTF-8?q?=F0=9F=A4=96=20Merge=20PR=20#66684=20fix(pg):?= =?UTF-8?q?=20add=20missing=20default=20configuration=20option=20by=20@stu?= =?UTF-8?q?ft2?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: add missing default configuration option * test: add tests for each of the global defaults --- types/pg/index.d.ts | 1 + types/pg/pg-tests.ts | 15 +++++++++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/types/pg/index.d.ts b/types/pg/index.d.ts index 94832a68f98473..cad77f52314498 100644 --- a/types/pg/index.d.ts +++ b/types/pg/index.d.ts @@ -41,6 +41,7 @@ export interface Defaults extends ClientConfig { reapIntervalMillis?: number | undefined; binary?: boolean | undefined; parseInt8?: boolean | undefined; + parseInputDatesAsUTC?: boolean | undefined; } export interface PoolConfig extends ClientConfig { diff --git a/types/pg/pg-tests.ts b/types/pg/pg-tests.ts index 780a8b5410590f..957c142ded0cec 100644 --- a/types/pg/pg-tests.ts +++ b/types/pg/pg-tests.ts @@ -1,12 +1,19 @@ -import { connect } from "net"; -import { Client, Connection, CustomTypesConfig, DatabaseError, Pool, QueryArrayConfig, types } from "pg"; -import TypeOverrides = require("pg/lib/type-overrides"); -import { NoticeMessage } from "pg-protocol/dist/messages"; +import { connect } from 'net'; +import { types, Client, CustomTypesConfig, QueryArrayConfig, Pool, DatabaseError, Connection, defaults } from 'pg'; +import TypeOverrides = require('pg/lib/type-overrides'); +import { NoticeMessage } from 'pg-protocol/dist/messages'; // https://github.com/brianc/node-pg-types // tslint:disable-next-line no-unnecessary-callback-wrapper types.setTypeParser(20, val => Number(val)); +const poolSize: number | undefined = defaults.poolSize; +const poolIdleTimeout: number | undefined = defaults.poolIdleTimeout; +const reapIntervalMillis: number | undefined = defaults.reapIntervalMillis; +const binary: boolean | undefined = defaults.binary; +const parseInt8: boolean | undefined = defaults.parseInt8; +const parseInputDatesAsUTC: boolean | undefined = defaults.parseInputDatesAsUTC; + const client = new Client({ host: "my.database-server.com", port: 5334,