Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/chroma-js: Generic type 'Scale<OutType, Color>' requires 2 type argument(s). #16979

Closed
ruffiem opened this issue Jun 5, 2017 · 4 comments

Comments

@ruffiem
Copy link

ruffiem commented Jun 5, 2017

I tried using @types/chroma-js v1.3.0 with typescript v2.2.0 and v2.3.0 and both crash while compiling with this output:

ERROR in /usr/local/var/www/projects/ztrim/node_modules/@types/chroma-js/index.d.ts (290,29): ',' expected.

ERROR in /usr/local/var/www/projects/ztrim/node_modules/@types/chroma-js/index.d.ts (202,66): Generic type 'Scale<OutType, Color>' requires 2 type argument(s).

ERROR in /usr/local/var/www/projects/ztrim/node_modules/@types/chroma-js/index.d.ts (204,38): Generic type 'Scale<OutType, Color>' requires 2 type argument(s).

...

ERROR in /usr/local/var/www/projects/ztrim/node_modules/@types/chroma-js/index.d.ts (352,18): Generic type 'Scale<OutType, Color>' requires 2 type argument(s).

Anyone to confirm ?

@diiq
Copy link
Contributor

diiq commented Jun 7, 2017

I can confirm this is also happening to me; chroma-js@1.3.4, @types/chroma-js@1.3.0.

Taking a look now.

@diiq
Copy link
Contributor

diiq commented Jun 7, 2017

Works with typescript@2.3.4 -- and should work back as far as 2.3; the 'comma expected' is due to the default generic, which was added in 2.3 (see microsoft/TypeScript#2175).

@ruffiem are you sure that, when you tried with Typescript 2.3.0, your build system was genuinely using it?

@ruffiem
Copy link
Author

ruffiem commented Jun 8, 2017

Actually, it was bugged on TypeScript 2.3.2 but not 2.3.4 👍

@orta
Copy link
Collaborator

orta commented Jun 7, 2021

Hi thread, we're moving DefinitelyTyped to use GitHub Discussions for conversations the @types modules in DefinitelyTyped.

To help with the transition, we're closing all issues which haven't had activity in the last 6 months, which includes this issue. If you think closing this issue is a mistake, please pop into the TypeScript Community Discord and mention the issue in the definitely-typed channel.

@orta orta closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants