Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaflet.locatecontrol has an incorrect type in interface LocateOptions #69139

Open
miklcct opened this issue Mar 23, 2024 Discussed in #69138 · 0 comments
Open

leaflet.locatecontrol has an incorrect type in interface LocateOptions #69139

miklcct opened this issue Mar 23, 2024 Discussed in #69138 · 0 comments

Comments

@miklcct
Copy link
Contributor

miklcct commented Mar 23, 2024

Discussed in #69138

Originally posted by miklcct March 23, 2024
In the type package, LocateOptions.createButtonCallback has type ((container: HTMLDivElement, options: LocateOptions) => void) | undefined, but in the source code, it says that the function "should return an object with HtmlElement for the button (link property) and the icon (icon property)."

As a result, TypeScript doesn't do the type check properly on the callback passed into the object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant