Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/selectize]: Missing parameter "silent" in methods clearOptions() and refreshItems() #69495

Open
AndreEckner opened this issue May 2, 2024 Discussed in #69428 · 2 comments · May be fixed by #69499
Open

[@types/selectize]: Missing parameter "silent" in methods clearOptions() and refreshItems() #69495

AndreEckner opened this issue May 2, 2024 Discussed in #69428 · 2 comments · May be fixed by #69499

Comments

@AndreEckner
Copy link

Discussed in #69428

Originally posted by AndreEckner April 24, 2024
There is a boolean|undefined parameter called silent in lots of the selecitze methods,
that handles whether the method should trigger a corresponding change-event.

This parameter exists as per now also in the two methods
clearOptions() and refreshItems().

Only for one of these cases is the parameter documented in the official API-Doc:
https://selectize.dev/docs/API/selectize#clearoptionssilent

For the missing documentation of refreshItems(silent) there currently exists an issue which nobody seems to care about:
selectize/selectize.js#2009

But both cases can be seen in the current code at Github by searching for the method names:
https://github.com/selectize/selectize.js/blob/master/dist/js/selectize.js

So the Typescript-definitions should be changed accordingly to:
clearOptions(silent?: boolean): void;
refreshItems(silent?: boolean): void;

@codershiba codershiba linked a pull request May 2, 2024 that will close this issue
8 tasks
@codershiba
Copy link
Contributor

Fixed in #69499

@AndreEckner
Copy link
Author

@codershiba Thanks! :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants