Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rating overrides should reflect in findings #966

Open
nscuro opened this issue Dec 13, 2023 · 0 comments · May be fixed by DependencyTrack/hyades-apiserver#489
Open

Rating overrides should reflect in findings #966

nscuro opened this issue Dec 13, 2023 · 0 comments · May be fixed by DependencyTrack/hyades-apiserver#489
Assignees
@nscuro
Labels
component/api-server defect Something isn't working p2 Non-critical bugs, and features that help organizations to identify and reduce risk size/S Small effort

Comments

@nscuro
Copy link
Member

nscuro commented Dec 13, 2023

The Findings query must be updated to reflect any applied rating overrides:

https://github.com/DependencyTrack/hyades-apiserver/blob/34884c9f395676b513374b3e3c0bf22ac4ccee78/src/main/java/org/dependencytrack/model/Finding.java#L56-L90

Currently, findings will report the original rating, despite them having been overwritten via analysis.

Note

This is also a good opportunity to rewrite the Finding query logic to use JDBI, and also add support for pagination.
@nscuro nscuro added defect Something isn't working p2 Non-critical bugs, and features that help organizations to identify and reduce risk size/S Small effort component/api-server labels Dec 13, 2023
@nscuro nscuro self-assigned this Dec 14, 2023
nscuro added a commit to DependencyTrack/hyades-apiserver that referenced this issue Dec 14, 2023
@nscuro
WIP: Consider rating overrides for findings
288f157 
Closes DependencyTrack/hyades#966

Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit to DependencyTrack/hyades-apiserver that referenced this issue Dec 15, 2023
@nscuro
Consider rating overrides for findings
432706e 
Additionally, refactor findings query to use JDBI and a single SQL statement, instead of multiple additional queries to enrich the results.

The new query also supports pagination, which the original logic didn't.

Closes DependencyTrack/hyades#966

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro linked a pull request Dec 15, 2023 that will close this issue
Draft
2 tasks
nscuro added a commit to DependencyTrack/hyades-apiserver that referenced this issue Dec 15, 2023
@nscuro
Consider rating overrides for findings
b4800ed 
Additionally, refactor findings query to use JDBI and a single SQL statement, instead of multiple additional queries to enrich the results.

The new query also supports pagination, which the original logic didn't.

Closes DependencyTrack/hyades#966

Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit to DependencyTrack/hyades-apiserver that referenced this issue Dec 15, 2023
@nscuro
Consider rating overrides for findings
c3a054a 
Additionally, refactor findings query to use JDBI and a single SQL statement, instead of multiple additional queries to enrich the results.

The new query also supports pagination, which the original logic didn't.

Closes DependencyTrack/hyades#966

Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit to DependencyTrack/hyades-apiserver that referenced this issue Dec 18, 2023
@nscuro
Consider rating overrides for findings
eb3eb5f 
Additionally, refactor findings query to use JDBI and a single SQL statement, instead of multiple additional queries to enrich the results.

The new query also supports pagination, which the original logic didn't.

Closes DependencyTrack/hyades#966

Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit to DependencyTrack/hyades-apiserver that referenced this issue Dec 22, 2023
@nscuro
Consider rating overrides for findings
b517714 
Additionally, refactor findings query to use JDBI and a single SQL statement, instead of multiple additional queries to enrich the results.

The new query also supports pagination, which the original logic didn't.

Closes DependencyTrack/hyades#966

Signed-off-by: nscuro <nscuro@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nscuro nscuro

Labels
component/api-server defect Something isn't working p2 Non-critical bugs, and features that help organizations to identify and reduce risk size/S Small effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Consider rating overrides for findings DependencyTrack/hyades-apiserver
1 participant
@nscuro