Thumbnail not show in app

[Monirzadeh]

app not show thumbnail of bookmarks.
in screenshot it is work but in my test not working. is it a bug or this feature not merge yet?

[DesarrolloAntonio]

I can see all the thumbnails, can you send me a link to try

[DesarrolloAntonio]

The first three bookmarks that I have did not have a thumbnail, I have deleted them, I have created them again and they are now available, perhaps it is a compatibility problem between versions

[Monirzadeh]

i test that with pagekeeper v 1.02 and stable release of shiori 1.5.5.
if i add link with Share menu thumbnail is show up but if you add that from shiori than refresh app thumbnail missing
for example test this link
https://www.1pezeshk.com/archives/2024/01/lactic-acid-isnt-making-your-muscles-sore.html

thumbnail work in shiori. in both way(share menu or directly add from server) .

if you refresh app ,is it check thumbnail for refresh too?

[DesarrolloAntonio]

i test that with pagekeeper v 1.02 and stable release of shiori 1.5.5. if i add link with Share menu thumbnail is show up but if you add that from shiori than refresh app thumbnail missing for example test this link https://www.1pezeshk.com/archives/2024/01/lactic-acid-isnt-making-your-muscles-sore.html

thumbnail work in shiori. in both way(share menu or directly add from server) .

if you refresh app ,is it check thumbnail for refresh too?

I've tested the link and the thumbnails look fine to me.

[Monirzadeh]

Do you add that from server or app?

[DesarrolloAntonio]

Do you add that from server or app?

From server

[DesarrolloAntonio]

Do you add that from server or app?

and from the app too

[Monirzadeh]

it happen to me time to time.

[DesarrolloAntonio]

it happen to me time to time.

Have you tried deleting the bookmark and adding it again?

[Monirzadeh]

yes. i remove that and add again but when i add them from server i missing thumbnail
server log show me

/bookmark/8/thumb                         proto=HTTP/1.1 remote="192.168.1.5:42606" reqlen=0 size=69 status=301

[DesarrolloAntonio]

I think I have found the problem. If the URL is saved in this format (http://192.168.1.12:8080/), when the image URL part is added (http://192.168.1.12:8080//bookmark/1/thumb), the slash / gets duplicated. I have implemented a control to remove the slash if it exists.

[Monirzadeh]

Hi.
I test latest release on Google Play (v1.05) unfortunately bug still exist.

[DesarrolloAntonio]

Hi. I test latest release on Google Play (v1.05) unfortunately bug still exist.

Can you create a user or environment where I could test from my device?

[Monirzadeh]

unfortunately in run that locally right now. shiori v1.5.5
but i get https://github.com/DesarrolloAntonio/Shiori-Android-Client/issues/2#issuecomment-1895838147 again in log.

[DesarrolloAntonio]

I've created this for google review, you can test in:
http://144.24.183.231:8085/
user: testing
pass: shiori

Let's see if you can add a bookmark where the thumbnail doesn't appear so I can try it.

[Monirzadeh]

is it version 1.5.5 ?
in my test title show url becuse of this bug that fixed in 1.6 rc1.
but in your server thumbnail show correctly and title show correct (instead of url)
on your server

my local test on shiori v 1.55

(both show thumbnail on web version)

[DesarrolloAntonio]

I've installed Shiori in Docker using a template, but the template uses a very old version from this image: [https://hub.docker.com/r/radhifadlillah/shiori/tags]. I'll try to update the container.

[DesarrolloAntonio]

I've created a new container using the latest image, but the thumbnail is not showing in the app, now I can fix the bug. Here are the server details with the same credentials.
http://144.24.183.231:8086/

[DesarrolloAntonio]

In my case the problem was that de bookmark was not public, and there was no access to the image. I have edited the bookmark to make it public, and now it appears.

[DesarrolloAntonio]

[Monirzadeh]

you right when i remove bookmark and add that as public bookmark it finally show thumbnail.
so maybe you don't send token for request thumbnail in code (which part of code responsible for request thumbnail?)

as i remember fmartingr migrate UI route in v1.6 this
go-shiori/shiori#775 and close issue go-shiori/shiori#660.
and for private thumbnail you need to authorize

are you sure that send token to accesses thumbnail?

[DesarrolloAntonio]

I'm using the direct url
http://144.24.183.231:8086/bookmark/1/thumb

[Monirzadeh]

I'm using the direct url http://144.24.183.231:8086/bookmark/1/thumb

so you don't send token in request or cookies to accesses that.
i set that bookmark as private and you can accesses thumbnail if you are not login.
you need attach cookies at least to accesses that.

[DesarrolloAntonio]

I can't send cookies from Android in a straightforward way. The only thing I can think of is to send the sessionID as a parameter in the URL

[Monirzadeh]

you can add token to header like other request

 curl -H "Authorization: Bearer userToken" http://127.0.0.1:8080/bookmark/1/thumb -o thumb.png  

this request work on shiori 1.6 for me. to authorize and accesses to the thumbnail. if i am not send a valid token that redirect me to the login page

[Monirzadeh]

as you see fmartingr done that for wbeui of shiori that in this PR
go-shiori/shiori#743

[DesarrolloAntonio]

In legacy api, I haven't token
{"session":"3bd057b0-196e-43f6-95bb-4680ef966b7f","account":{"id":1,"username":"testing","owner":true},"expires":"Tue, 23 Jan 2024 13:28:18 UTC"}

[Monirzadeh]

In legacy api, I haven't token {"session":"3bd057b0-196e-43f6-95bb-4680ef966b7f","account":{"id":1,"username":"testing","owner":true},"expires":"Tue, 23 Jan 2024 13:28:18 UTC"}

you right we add that in shiori v1.6 with this PR go-shiori/shiori#742
in this line
https://github.com/go-shiori/shiori/blob/84e5b09c4c9944fc881ad6e1c6a5224b6fa07e42/internal/view/login.html#L127

maybe not bad if you add a lable to this issue "migrate new api" and fix that when you start working in new api.
at least we found the source of problem.

[DesarrolloAntonio]

I've solved the problem including the X-Session-Id in the headers.

[graphixillusion]

I'm still having the problem. I can't see anymore the images in the saved bookmarks. I'm using the last version of the app in android 9