Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Visual Regression Testing #43

Open
hisk opened this issue Oct 8, 2018 · 2 comments
Open

Add Visual Regression Testing #43

hisk opened this issue Oct 8, 2018 · 2 comments

Comments

@hisk
Copy link
Contributor

hisk commented Oct 8, 2018

Problem

Currently, there are no public visual regression tests in Shards and I think this would be the next step towards a more integrated and modern development process.

Solution

The best course of action here I think would be to use BackstopJS and have a test npm script that runs it against an array of scenarios isolated inside a tests/ directory for mobile, tablet and desktop viewports. I'm open to suggestions if someone can come up with a better alternative to Backstop, but I would prefer a self-contained solution.

Each scenario can be a simple template with isolated components for a specific category. I'll work on the exact list during the next couple of days.

Action Items

  • (optional) Suggest an alternative to Backstop, if any.
  • Integrate, initialize and configure Backstop in Shards.
  • Add test script.
  • (optional) Add a sample scenario with a demo component and reference.
@sidalidev
Copy link

How about Snapshot testing with Jest ?

@hisk
Copy link
Contributor Author

hisk commented Oct 9, 2018

@sidbentifraouine Thanks for your suggestion and sorry for the delay! 😃 I assume you are referring to using Jest with jest-image-snapshot. I guess that would work too, but wouldn't it require some more boilerplate? I might be wrong. 🤔

Can you clarify what setup you have in mind and how it would benefit more than using Backstop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants