Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass transfers not working in Edge. #3324

Closed
lowPolySkeleton opened this issue Nov 16, 2018 · 10 comments
Closed

Mass transfers not working in Edge. #3324

lowPolySkeleton opened this issue Nov 16, 2018 · 10 comments

Comments

@lowPolySkeleton
Copy link
Member

mass transfer issue in edge, beta and prod. This applies to gather rep items, loadouts, and search / transfer.

I tested in Microsoft Edge 42.17134.1.0

Prod console logs:
SCRIPT5007: Unable to get property 'props' of undefined or null reference react-dom.production.min.js (21,62)

Beta console logs:
SCRIPT5007: Unable to get property 'props' of undefined or null reference helpers.ts (79,14)

nothing happens in game or in app no failure toaster just the console error.

@bhollis bhollis added the Bug label Nov 18, 2018
@bhollis
Copy link
Contributor

bhollis commented Nov 18, 2018

Manage to figure out what's going on here?

@lowPolySkeleton
Copy link
Member Author

I think @48klocs was looking into this one, I’ll do some testing when I can though the errors are... less than helpful.

@48klocs
Copy link
Contributor

48klocs commented Nov 19, 2018

I didn't get much further with it - I was able to (briefly) see the helpers.ts file, which mentioned "Sentry" and "Raven."

I don't know if Edge doesn't like click events on spans or what.

@lowPolySkeleton
Copy link
Member Author

lowPolySkeleton commented Nov 19, 2018

I got nothing on this one... In beta that helper.ts error leads you to a try catch with a note about sentry.. I dunno if that is useful at all.
image

edit: heh jynx...

@bhollis
Copy link
Contributor

bhollis commented Nov 19, 2018

Yeah, that's just Sentry catching and logging the error. The real error is higher up.

@bhollis
Copy link
Contributor

bhollis commented Dec 20, 2018

I believe this is chakra-core/ChakraCore#4663, fixed in Edge 18 (which is the last ever Edge release AFAIK).

@bhollis
Copy link
Contributor

bhollis commented Dec 20, 2018

Upgrading @babel/preset-env should fix it.

@bhollis
Copy link
Contributor

bhollis commented Dec 20, 2018

Actually, we need babel/babel#9060, which hasn't been released yet.

@bhollis
Copy link
Contributor

bhollis commented Dec 20, 2018

OK, I pushed a change to beta - does it work now?

@lowPolySkeleton
Copy link
Member Author

Yes! loadout transfers seem to be working in edge on beta now!

@bhollis bhollis closed this as completed Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants