Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case where a parent of ~/.nix-defexpr is a symlink #10391

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Apr 3, 2024

Motivation

Fixes DeterminateSystems/nix-installer#912 and probably #10247.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@edolstra edolstra added the backport 2.21-maintenance Automatically creates a PR against the branch label Apr 3, 2024
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Apr 3, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/error-path-home-is-a-symlink/42267/5

Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll eventually want something more systematic that just adding resolveSymlinks more and more places, but it is good to have a fix with a regression test.

@edolstra edolstra enabled auto-merge April 3, 2024 14:47
@edolstra edolstra merged commit bf86b93 into NixOS:master Apr 3, 2024
9 checks passed
Copy link

github-actions bot commented Apr 3, 2024

Successfully created backport PR for 2.21-maintenance:

Copy link

github-actions bot commented Apr 3, 2024

Successfully created backport PR for 2.20-maintenance:

Copy link

github-actions bot commented Apr 3, 2024

Backport failed for 2.21-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.21-maintenance
git worktree add -d .worktree/backport-10391-to-2.21-maintenance origin/2.21-maintenance
cd .worktree/backport-10391-to-2.21-maintenance
git switch --create backport-10391-to-2.21-maintenance
git cherry-pick -x 09551fabd092fe26d6b6a13417502a514fbd78b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.20-maintenance Automatically creates a PR against the branch backport 2.21-maintenance Automatically creates a PR against the branch with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: path '/home' is a symlink
3 participants