Skip to content

Hammerhead breaks scripts that save WindowPrototype to a property #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AndreyBelym opened this issue Nov 12, 2018 · 1 comment
Closed

Hammerhead breaks scripts that save WindowPrototype to a property #1828

AndreyBelym opened this issue Nov 12, 2018 · 1 comment
Assignees
@miherlosev
Labels
STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Milestone
Sprint #22

Comments

@AndreyBelym
Copy link
Contributor

page.html
<html>
 <head>
 </head>
 <body>
 <script>
 let prop = 0;
 const arr = [window.constructor.prototype];
 console.log(arr[prop]);
 </script>
 </body>
</html>

The problem is in the isShadowUIElement function: IE throws an error when accessing the WindowPrototype.window property.

isShadowUIElement is invoked in the property getter function here: https://github.com/DevExpress/testcafe-hammerhead/blob/master/src/client/sandbox/code-instrumentation/properties/index.js#L119
@AndreyBelym AndreyBelym added this to the Planned milestone Nov 12, 2018
@miherlosev miherlosev modified the milestones: Planned, Sprint #21 Nov 12, 2018
miherlosev pushed a commit to miherlosev/testcafe-hammerhead that referenced this issue Nov 16, 2018
fix 'Hammerhead breaks scripts that save WindowPrototype to a propert…
aecdc16 
…y' (close DevExpress#1828)
@LavrovArtem LavrovArtem modified the milestones: Sprint #21, Sprint #22 Nov 19, 2018
miherlosev pushed a commit to miherlosev/testcafe-hammerhead that referenced this issue Nov 19, 2018
fix 'Hammerhead breaks scripts that save WindowPrototype to a propert…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
856d630 
…y' (close DevExpress#1828)
@LavrovArtem LavrovArtem mentioned this issue Nov 26, 2018
Closed
AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this issue Feb 28, 2019
@miherlosev @AndreyBelym
fix 'Hammerhead breaks scripts that save WindowPrototype to a propert…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4f5f7af 
…y' (close DevExpress#1828) (DevExpress#1841)

* fix 'Hammerhead breaks scripts that save WindowPrototype to a property' (close DevExpress#1828)

* small refactoring
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked Issues that were automatically locked by the Lock bot label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miherlosev miherlosev

Labels
STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Projects
None yet
Milestone
Sprint #22
Development

No branches or pull requests
3 participants
@miherlosev @AndreyBelym @LavrovArtem