Add support for HTMLElement.removeAttributeNode. #2742
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
HTMLElement.attributes
returns an attributes wrapper that clones stored attribute nodes. Iterating over the attributes and passing a cloned attribute to HTMLElement.removeAttributeNode results in an exception that fails tests.Approach
Add support for
HTMLElement.removeAttributeNode
that reuses theremoveAttributeCore
implementation and supports namespaced attributes. Base attribute node and removeAttributeNode usage on the DOM living standard. Attempt to remove stored nodes, but continue not to the throw. Pass the attribute from the native attributes list to the nativeremoveAttributeNode
, and allow the call torefreshAttributesWrapper
to remove it or the clone from the wrapper. Add string representation and method unit tests, and base them on the existing tests forremoveAttribute
. Native function argument DOM tests don't apply. Make a concerted effort to match existing code style.References
Pre-Merge TODO