From 3157b6fc04c98b225a1c506e10b00ae99980ebbf Mon Sep 17 00:00:00 2001 From: Aleksey Popov Date: Wed, 23 Nov 2022 12:51:09 +0400 Subject: [PATCH] fix: fixed getSelectElementSize --- src/client/utils/style.ts | 2 +- test/client/fixtures/utils/style-test.js | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/client/utils/style.ts b/src/client/utils/style.ts index 589d79aa3..fb6ab395e 100644 --- a/src/client/utils/style.ts +++ b/src/client/utils/style.ts @@ -207,7 +207,7 @@ export function getSelectElementSize (select) { return 1; const sizeAttr = nativeMethods.getAttribute.call(select, 'size'); - const multipleAttr = nativeMethods.getAttribute.call(select, 'multiple'); + const multipleAttr = nativeMethods.hasAttribute.call(select, 'multiple'); let size = !sizeAttr ? 1 : parseInt(sizeAttr, 10); if (multipleAttr && (!sizeAttr || size < 1)) diff --git a/test/client/fixtures/utils/style-test.js b/test/client/fixtures/utils/style-test.js index 40c30c8de..f55cd8662 100644 --- a/test/client/fixtures/utils/style-test.js +++ b/test/client/fixtures/utils/style-test.js @@ -270,7 +270,8 @@ test('getSelectElementSize', function () { strictEqual(size, 4); select.removeAttribute('size'); - select.setAttribute('multiple', 'multiple'); + select.setAttribute('multiple', ''); + size = styleUtils.getSelectElementSize(select); if (browserUtils.isSafari && featureDetection.hasTouchEvents || browserUtils.isAndroid) strictEqual(size, 1);